Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding integ tests for scenario of hybrid query with aggregations #632

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Mar 12, 2024

Description

Adding more integration tests for aggregations when they are used together with hybrid query. Picked 20 aggregations from official documentation.

Key points:

  • each aggregation test has two flavors: with and without concurrent search
  • added flag that controls if these tests needs to be executed or skipped as part of the full integ test suite run. By default tests are skipped
  • added github action that runs all tests daily

Example of test run:

./gradlew ':integTest' -Dtest_aggs=true --tests "org.opensearch.neuralsearch.query.aggregation.*IT"

=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.4
  OS Info               : Mac OS X 13.6.4 (x86_64)
  JDK Version           : 21 (Amazon Corretto JDK)
  JAVA_HOME             : /Users/user/.sdkman/candidates/java/21.0.1-amzn
  Random Testing Seed   : 449B74C95C0B7B77
  In FIPS 140 mode      : false
=======================================

> Task :integTest
Mar 12, 2024 3:33:35 PM sun.util.locale.provider.LocaleProviderAdapter <clinit>
WARNING: COMPAT locale provider will be removed in a future release

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.4/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 3m 2s
22 actionable tasks: 3 executed, 19 up-to-date

Issues Resolved

#509

Check List

  • New functionality includes testing.
    • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (fcb80a3) to head (edd02e3).
Report is 12 commits behind head on main.

❗ Current head edd02e3 differs from pull request most recent head 19e2adf. Consider uploading reports for the commit 19e2adf to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #632   +/-   ##
=========================================
  Coverage     82.62%   82.62%           
  Complexity      666      666           
=========================================
  Files            52       52           
  Lines          2072     2072           
  Branches        334      334           
=========================================
  Hits           1712     1712           
  Misses          212      212           
  Partials        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-gaievski martin-gaievski force-pushed the add_integ_tests_for_aggregations_and_hybrid_query branch 7 times, most recently from 0b4333e to a666584 Compare March 12, 2024 23:39
@martin-gaievski martin-gaievski changed the title Adding integ tests for aggregations when they're bundled with hybrid query Adding integ tests for scenario of hybrid query with aggregations Mar 14, 2024
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski force-pushed the add_integ_tests_for_aggregations_and_hybrid_query branch 3 times, most recently from d1f434d to 78d0c2f Compare March 14, 2024 21:29
@martin-gaievski martin-gaievski marked this pull request as ready for review March 14, 2024 22:07
@martin-gaievski martin-gaievski force-pushed the add_integ_tests_for_aggregations_and_hybrid_query branch from 78d0c2f to edd02e3 Compare March 15, 2024 00:05
@martin-gaievski martin-gaievski added the Maintenance Add support for new versions of OpenSearch/Dashboards from upstream label Apr 18, 2024
@martin-gaievski martin-gaievski force-pushed the add_integ_tests_for_aggregations_and_hybrid_query branch from edd02e3 to 2feadd2 Compare April 18, 2024 23:43
…angelog

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski force-pushed the add_integ_tests_for_aggregations_and_hybrid_query branch from 2feadd2 to 19e2adf Compare April 18, 2024 23:46
@martin-gaievski martin-gaievski merged commit dd3b30c into opensearch-project:main Apr 19, 2024
69 of 75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2024
* Adding tests and params to ignore tests if needed

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit dd3b30c)
martin-gaievski added a commit to martin-gaievski/neural-search that referenced this pull request Apr 19, 2024
…ensearch-project#632)

* Adding tests and params to ignore tests if needed

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit dd3b30c)
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski added a commit that referenced this pull request Apr 20, 2024
…) (#700)

* Adding tests and params to ignore tests if needed


(cherry picked from commit dd3b30c)

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Co-authored-by: Martin Gaievski <gaievski@amazon.com>
conggguan pushed a commit to conggguan/neural-search that referenced this pull request Apr 22, 2024
* Adding integ tests for scenario of hybrid query with aggregations (opensearch-project#632)

* Adding tests and params to ignore tests if needed

Signed-off-by: Martin Gaievski <gaievski@amazon.com>

* [BUG FIX] Fix bwc failure in neural sparse search (opensearch-project#696)

* fix comments

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

---------

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Co-authored-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch Maintenance Add support for new versions of OpenSearch/Dashboards from upstream v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants