Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch processor IT to use Lucene #48

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

jmazanec15
Copy link
Member

Description

Currently, Processor IT silently fails because it relies on k-NN plugin's nmslib jni library which is not shipped with the zip at the moment. It fails silently because on ingest, the index is not refreshed.

Updated processor test to use Lucene engine to avoid dependency issue. Refactored ingest document to refresh after ingestion and confirm doc gets indexed.

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Updated processor test to use Lucene engine. Refactored ingest document
to refresh after ingestion and confirm doc gets indexed.

Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 requested a review from a team November 1, 2022 17:33
@jmazanec15 jmazanec15 added Infrastructure backport 2.4 backport 2.x Label will add auto workflow to backport PR to 2.x branch labels Nov 1, 2022
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

It will be good to have these tests run with other engines as well. We can take in other Pr

@jmazanec15 jmazanec15 merged commit 0b8c0d1 into opensearch-project:main Nov 1, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 1, 2022
Updated processor test to use Lucene engine. Refactored ingest document
to refresh after ingestion and confirm doc gets indexed.

Signed-off-by: John Mazanec <jmazane@amazon.com>
(cherry picked from commit 0b8c0d1)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 1, 2022
Updated processor test to use Lucene engine. Refactored ingest document
to refresh after ingestion and confirm doc gets indexed.

Signed-off-by: John Mazanec <jmazane@amazon.com>
(cherry picked from commit 0b8c0d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch backport 2.4 Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants