Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [bug fix] Fix async actions are left in neural_sparse query #441

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 51e6c00 from #438

* add serialization and deserialization

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* hash, equals. + UT

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* tidy

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* add test

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

---------

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
(cherry picked from commit 51e6c00)
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #441 (3e57d7d) into 2.x (0ed523b) will increase coverage by 0.04%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##                2.x     #441      +/-   ##
============================================
+ Coverage     80.71%   80.75%   +0.04%     
- Complexity      502      510       +8     
============================================
  Files            41       41              
  Lines          1576     1590      +14     
  Branches        241      247       +6     
============================================
+ Hits           1272     1284      +12     
  Misses          201      201              
- Partials        103      105       +2     
Files Coverage Δ
...h/neuralsearch/query/NeuralSparseQueryBuilder.java 67.62% <86.66%> (+2.02%) ⬆️

@heemin32 heemin32 merged commit 87d6e5e into 2.x Oct 11, 2023
15 of 30 checks passed
@heemin32 heemin32 deleted the backport/backport-438-to-2.x branch October 11, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants