Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the locale changes from locale.default to locale.ROOT to fix the tests failing on windows. #43

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

navneet1v
Copy link
Collaborator

@navneet1v navneet1v commented Oct 29, 2022

Description

Fixing the locale changes from locale.default to locale.ROOT to fix the tests failing on windows.

Signed-off-by: Navneet Verma navneev@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…he tests failing on windows.

Signed-off-by: Navneet Verma <navneev@amazon.com>
@navneet1v navneet1v requested a review from a team October 29, 2022 00:02
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@navneet1v navneet1v merged commit 9c2739c into opensearch-project:main Oct 29, 2022
@navneet1v navneet1v added the bug Something isn't working label Oct 29, 2022
@jmazanec15 jmazanec15 added the Bug Fixes Changes to a system or product designed to handle a programming bug/glitch label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes Changes to a system or product designed to handle a programming bug/glitch bug Something isn't working v2.4.0 windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants