-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/backport 208 to 2.x #210
Backport/backport 208 to 2.x #210
Conversation
Signed-off-by: Zan Niu <zaniu@amazon.com>
Signed-off-by: Zan Niu <zaniu@amazon.com>
…rch-project#208) * Fix update document with knnn_vector size not matching issue Signed-off-by: zane-neo <zaniu@amazon.com> * Add apache common lang3 back to fix PR gradle build failure Signed-off-by: zane-neo <zaniu@amazon.com> * Fix PR check failure Signed-off-by: zane-neo <zaniu@amazon.com> * Fix PR check failure Signed-off-by: zane-neo <zaniu@amazon.com> * Fix PR check jar hell failure Signed-off-by: zane-neo <zaniu@amazon.com> * Add apache common lang back to fix the PR check Signed-off-by: zane-neo <zaniu@amazon.com> * Fix register model group failure in IT Signed-off-by: zane-neo <zaniu@amazon.com> * format code Signed-off-by: zane-neo <zaniu@amazon.com> * Rename the method appendVectorFieldsToDocument to setVectorFieldsToDocument Signed-off-by: zane-neo <zaniu@amazon.com> * format code Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> (cherry picked from commit 9599371)
Signed-off-by: zane-neo <zaniu@amazon.com>
@@ -36,6 +36,8 @@ public class MLCommonsClientAccessor { | |||
private static final List<String> TARGET_RESPONSE_FILTERS = List.of("sentence_embedding"); | |||
private final MachineLearningNodeClient mlClient; | |||
|
|||
private static final int MAX_RETRY = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I followed the guidance of backport on github, this could be missing removal in previous backport PRs. I've removed this.
Signed-off-by: zane-neo <zaniu@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #210 +/- ##
=========================================
Coverage 89.55% 89.55%
Complexity 103 103
=========================================
Files 7 7
Lines 316 316
Branches 52 52
=========================================
Hits 283 283
Misses 16 16
Partials 17 17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zane-neo we should close this PR. The backport has already happened for 2.x branch |
Description
This PR fixed the issue when updating a document with knn_vector field, the update fails because the vector dimension is not matching the required dimension. This PR is a backport PR of: #208
Issues Resolved
#207
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.