Fixed flaky integration test for explain in hybrid query #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
added
backport 2.x
ryanbogan
approved these changes
Jan 17, 2025
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
ryanbogan
approved these changes
Jan 21, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 84e6306)
martin-gaievski
added a commit
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 84e6306)
heemin32
pushed a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flaky test results are caused by shared index names. Different tests do change documents in unpredictable manner, that causes test results to be non deterministic, and test level assertions may fail.
Related Issues
#1120
Check List
[ ] New functionality includes testing.[ ] New functionality has been documented.[ ] API changes companion pull request created.--signoff.[ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.