integrate tribuo anomaly detection based on libSVM #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
force-pushed
the
libsvm
branch
2 times, most recently
from
c102aa4 to
064e441
Compare
ylwu-amzn
force-pushed
the
libsvm
branch
2 times, most recently
from
477bc0e to
69594a7
Compare
Zhangxunmt
previously approved these changes
Feb 4, 2022
| } | ||
|
|
||
| @Override | ||
| public int getVersion() { |
There was a problem hiding this comment.
Just curious: this version is always 1?
There was a problem hiding this comment.
We set version as 1 for first release. May change to higher version in future
Comment on lines
+96
to
+117
| KernelType kernelType = parseKernelType(); | ||
| SVMParameters params = new SVMParameters<>(new SVMAnomalyType(SVMAnomalyType.SVMMode.ONE_CLASS), kernelType); | ||
| Double gamma = Optional.ofNullable(parameters.getGamma()).orElse(DEFAULT_GAMMA); | ||
| Double nu = Optional.ofNullable(parameters.getNu()).orElse(DEFAULT_NU); | ||
| params.setGamma(gamma); | ||
| params.setNu(nu); | ||
| if (parameters.getCost() != null) { | ||
| params.setCost(parameters.getCost()); | ||
| } | ||
| if (parameters.getCoeff() != null) { | ||
| params.setCoeff(parameters.getCoeff()); | ||
| } | ||
| if (parameters.getEpsilon() != null) { | ||
| params.setEpsilon(parameters.getEpsilon()); | ||
| } | ||
| if (parameters.getDegree() != null) { | ||
| params.setDegree(parameters.getDegree()); | ||
| } | ||
| MutableDataset<Event> data = TribuoUtil.generateDataset(dataFrame, new AnomalyFactory(), | ||
| "Anomaly detection LibSVM training data from OpenSearch", TribuoOutputType.ANOMALY_DETECTION_LIBSVM); | ||
|
|
||
| LibSVMAnomalyTrainer trainer = new LibSVMAnomalyTrainer(params); |
There was a problem hiding this comment.
nitpick: why not use a function to instantiate the params and LibSVMAnomalyTrainer to make the train() body smaller?
There was a problem hiding this comment.
Will tune this part in next PR.
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Zhangxunmt
approved these changes
Feb 4, 2022
jackiehanyang
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
Integrate tribuo anomaly detection algorithm which based on libSVM. Check this doc https://tribuo.org/learn/4.1/docs/features.html#anomaly-detection
Issues Resolved
#98
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.