Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check hash value in register model API #878

Merged
merged 1 commit into from
May 3, 2023

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented May 2, 2023

Description

Add hash value validation step in register model API.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jing Zhang <jngz@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #878 (844aca2) into 2.x (90e5ea0) will increase coverage by 0.05%.
The diff coverage is 77.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #878      +/-   ##
============================================
+ Coverage     84.06%   84.12%   +0.05%     
- Complexity     1749     1756       +7     
============================================
  Files           139      139              
  Lines          6721     6752      +31     
  Branches        669      673       +4     
============================================
+ Hits           5650     5680      +30     
  Misses          774      774              
- Partials        297      298       +1     
Flag Coverage Δ
ml-commons 84.12% <77.77%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/ml/profile/MLModelProfile.java 62.50% <0.00%> (ø)
...ain/java/org/opensearch/ml/engine/ModelHelper.java 88.28% <100.00%> (+0.66%) ⬆️
...n/java/org/opensearch/ml/model/MLModelManager.java 77.80% <100.00%> (+0.04%) ⬆️

... and 5 files with indirect coverage changes

@jngz-es jngz-es merged commit 22ae4ca into opensearch-project:2.x May 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2023
Signed-off-by: Jing Zhang <jngz@amazon.com>
(cherry picked from commit 22ae4ca)
jngz-es added a commit that referenced this pull request May 4, 2023
Signed-off-by: Jing Zhang <jngz@amazon.com>
(cherry picked from commit 22ae4ca)

Co-authored-by: Jing Zhang <jngz@amazon.com>
@jngz-es jngz-es deleted the hash_check branch May 23, 2023 20:47
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Aug 24, 2023
Signed-off-by: Jing Zhang <jngz@amazon.com>
zane-neo added a commit that referenced this pull request Aug 24, 2023
Signed-off-by: Jing Zhang <jngz@amazon.com>
Co-authored-by: Jing Zhang <jngz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants