Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allow custom deployment plan setting; add deploy to all nodes field in model index #818

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

  1. Add allow custom deployment plan setting, set default value as false, which means by default user can't deploy model to specified node ids.
  2. Add deploy to all nodes field in model index.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ld in model index

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn requested a review from a team March 22, 2023 01:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Merging #818 (09ac78c) into 2.x (aac0926) will decrease coverage by 0.24%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #818      +/-   ##
============================================
- Coverage     85.14%   84.90%   -0.24%     
- Complexity     1624     1626       +2     
============================================
  Files           135      135              
  Lines          6003     6036      +33     
  Branches        580      589       +9     
============================================
+ Hits           5111     5125      +14     
- Misses          646      659      +13     
- Partials        246      252       +6     
Flag Coverage Δ
ml-commons 84.90% <50.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 98.82% <ø> (ø)
...n/java/org/opensearch/ml/cluster/MLSyncUpCron.java 76.40% <37.93%> (-8.12%) ⬇️
...earch/ml/action/load/TransportLoadModelAction.java 84.29% <77.77%> (+0.22%) ⬆️
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn ylwu-amzn merged commit 4df13e3 into opensearch-project:2.x Mar 22, 2023
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 22, 2023
…ld in model index (opensearch-project#818)

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn added a commit that referenced this pull request Mar 22, 2023
…ld in model index (#818) (#820)

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants