Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exclude nodes setting #813

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Add exclude nodes setting.
If user don't want to run ML tasks on some ML nodes, they can use exclude the nodes with this setting.

Issues Resolved

#812

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn requested a review from a team March 21, 2023 16:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Merging #813 (e9d8054) into 2.x (894f983) will increase coverage by 0.28%.
The diff coverage is 78.37%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #813      +/-   ##
============================================
+ Coverage     84.82%   85.10%   +0.28%     
- Complexity     1598     1622      +24     
============================================
  Files           135      135              
  Lines          5971     6003      +32     
  Branches        570      580      +10     
============================================
+ Hits           5065     5109      +44     
+ Misses          663      648      -15     
- Partials        243      246       +3     
Flag Coverage Δ
ml-commons 85.10% <78.37%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 98.82% <ø> (ø)
.../java/org/opensearch/ml/task/MLTaskDispatcher.java 32.94% <0.00%> (ø)
...h/ml/action/unload/TransportUnloadModelAction.java 77.10% <25.00%> (-1.91%) ⬇️
...org/opensearch/ml/cluster/DiscoveryNodeHelper.java 95.23% <83.33%> (+5.84%) ⬆️
...n/java/org/opensearch/ml/model/MLModelManager.java 78.92% <90.90%> (+0.29%) ⬆️
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <100.00%> (ø)
...va/org/opensearch/ml/task/MLPredictTaskRunner.java 82.14% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Zhangxunmt
Zhangxunmt previously approved these changes Mar 21, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn merged commit aac0926 into opensearch-project:2.x Mar 21, 2023
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 21, 2023
* add exclude nodes setting

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix duplicate nodes if node has both ml and data roles

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn added a commit that referenced this pull request Mar 22, 2023
* add exclude nodes setting



* fix duplicate nodes if node has both ml and data roles



---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants