Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main]Adding backwards compatibility test for ml-commons plugin (#681) #776

Closed
wants to merge 7 commits into from

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Backport #681 to main branch

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn requested a review from a team March 2, 2023 19:42
@opensearch-trigger-bot opensearch-trigger-bot bot added documentation Improvements or additions to documentation infra labels Mar 2, 2023
b4sjoo and others added 2 commits March 2, 2023 12:04
…-project#681)

* Adding backwards compatibility test for ml-commons plugin

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Adjust gradle build file to create bwc tasks

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Add bwc test to CI workflow and developer guide

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Add gradle test filter so BWC test can only run within the BWC gradle task bwcsuite or its dependent tasks

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* bug fix for bwc test

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Fix running on ml node issue

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
jngz-es and others added 5 commits March 2, 2023 12:21
* Add native memory circuit breaker.
Refactor all breakers from common to plugin.
Add dynamic setting for native memory circuit breaker.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address the comments 1.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Spotless changes.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address the comments 2.

Signed-off-by: Jing Zhang <jngz@amazon.com>

Signed-off-by: Jing Zhang <jngz@amazon.com>
* Change the inheritance of the BWC test file

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* SpotlessApply

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn changed the title Adding backwards compatibility test for ml-commons plugin (#681) [Backport to main]Adding backwards compatibility test for ml-commons plugin (#681) Mar 2, 2023
@ylwu-amzn
Copy link
Collaborator Author

BWC has some issue. Will backport other PRs first.
Close this PR

@ylwu-amzn ylwu-amzn closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants