[Backport 3.3] Fix agent type update #4481

opensearch-trigger-bot · 2025-12-02T00:49:43Z

Backport 79cbcfb from #4341

coderabbitai · 2025-12-02T00:49:49Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch backport/backport-4341-to-3.3

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentUpdateInput.java

common/src/main/java/org/opensearch/ml/common/CommonValue.java

owaiskazi19 · 2025-12-02T01:44:33Z

common/src/main/java/org/opensearch/ml/common/CommonValue.java

    public static final Version VERSION_3_1_0 = Version.fromString("3.1.0");
    public static final Version VERSION_3_2_0 = Version.fromString("3.2.0");
    public static final Version VERSION_3_3_0 = Version.fromString("3.3.0");
+    public static final Version VERSION_3_4_0 = Version.fromString("3.4.0");


Can remove this

owaiskazi19 · 2025-12-02T01:44:40Z

common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentUpdateInput.java

 import static org.opensearch.core.xcontent.XContentParserUtils.ensureExpectedToken;
 import static org.opensearch.ml.common.CommonValue.TENANT_ID_FIELD;
 import static org.opensearch.ml.common.CommonValue.VERSION_2_19_0;
+import static org.opensearch.ml.common.CommonValue.VERSION_3_4_0;


and this too

common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentUpdateInput.java

owaiskazi19 · 2025-12-02T19:45:41Z

Unrelated failure

RestBedRockInferenceIT > test_bedrock_multimodal_model_empty_imageInput_null_textInput STANDARD_OUT
    [2025-12-02T01:34:41,581][INFO ][o.o.m.r.RestBedRockInferenceIT] [test_bedrock_multimodal_model_empty_imageInput_null_textInput] before test
    [2025-12-02T01:34:41,589][INFO ][o.o.m.r.RestBedRockInferenceIT] [test_bedrock_multimodal_model_empty_imageInput_null_textInput] initializing REST clients against [http://[::1]:37653, http://127.0.0.1:42145]
Error: 25-12-02T01:35:02,656][ERROR][o.o.m.r.MLCommonsRestTestCase] [test_bedrock_multimodal_model_empty_imageInput_null_textInput] method [POST], host [http://127.0.0.1:42145/], URI [/_plugins/_ml/_predict/TEXT_EMBEDDING/U9Bq3poBtGxTpHvlVo_2], status line [HTTP/1.1 400 Bad Request]
    {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"No input text or image provided"}],"type":"illegal_argument_exception","reason":"No input text or image provided"},"status":400}
    org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:42145/], URI [/_plugins/_ml/_predict/TEXT_EMBEDDING/U9Bq3poBtGxTpHvlVo_2], status line [HTTP/1.1 400 Bad Request]
    {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"No input text or image provided"}],"type":"illegal_argument_exception","reason":"No input text or image provided"},"status":400}
    	at org.opensearch.client.RestClient.convertResponse(RestClient.java:501) ~[opensearch-rest-client-3.3.2-SNAPSHOT.jar:3.3.2-SNAPSHOT]
    	at org.opensearch.client.RestClient.performRequest(RestClient.java:384) ~[opensearch-rest-client-3.3.2-SNAPSHOT.jar:3.3.2-SNAPSHOT]
    	at org.opensearch.client.RestClient.performRequest(RestClient.java:359) ~[opensearch-rest-client-3.3.2-SNAPSHOT.jar:3.3.2-SNAPSHOT]
    	at org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:199) ~[test/:?]
    	at org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:172) ~[test/:?]
    	at org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:161) ~[test/:?]
    	at org.opensearch.ml.rest.MLCommonsRestTestCase.predictTextEmbeddingModel(MLCommonsRestTestCase.java:925) ~[test/:?]
    	at org.opensearch.ml.rest.RestBedRockInferenceIT.test_bedrock_multimodal_model_empty_imageInput_null_textInput(RestBedRockInferenceIT.ja

* Fix agent type update Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Added bwc checks Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated version Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit 79cbcfb)

…MLAgentUpdateInput.java Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

opensearch-trigger-bot bot requested review from HenryL27, Zhangxunmt, austintlee, b4sjoo, dhrubo-os, jngz-es, mingshl, model-collapse, pyek-bot, rbhavna, sam-herman, xinyual, ylwu-amzn and zane-neo as code owners December 2, 2025 00:49

opensearch-trigger-bot bot had a problem deploying to ml-commons-cicd-env December 2, 2025 00:51 Error

opensearch-trigger-bot bot had a problem deploying to ml-commons-cicd-env December 2, 2025 00:51 Failure

opensearch-trigger-bot bot had a problem deploying to ml-commons-cicd-env December 2, 2025 00:51 Error

owaiskazi19 reviewed Dec 2, 2025

View reviewed changes

common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentUpdateInput.java Outdated Show resolved Hide resolved

common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentUpdateInput.java Outdated Show resolved Hide resolved

b4sjoo previously approved these changes Dec 2, 2025

View reviewed changes

b4sjoo reviewed Dec 2, 2025

View reviewed changes

common/src/main/java/org/opensearch/ml/common/CommonValue.java Outdated Show resolved Hide resolved

owaiskazi19 reviewed Dec 2, 2025

View reviewed changes

b4sjoo reviewed Dec 2, 2025

View reviewed changes

common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentUpdateInput.java Outdated Show resolved Hide resolved

b4sjoo dismissed their stale review via 05d2390 December 2, 2025 01:45

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 01:46 — with GitHub Actions Error

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 01:46 — with GitHub Actions Failure

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 01:46 — with GitHub Actions Error

b4sjoo reviewed Dec 2, 2025

View reviewed changes

common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentUpdateInput.java Outdated Show resolved Hide resolved

b4sjoo approved these changes Dec 2, 2025

View reviewed changes

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 01:54 — with GitHub Actions Failure

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 01:54 — with GitHub Actions Error

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 01:54 — with GitHub Actions Failure

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 09:25 — with GitHub Actions Error

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 09:25 — with GitHub Actions Failure

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 09:25 — with GitHub Actions Error

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 09:25 — with GitHub Actions Failure

owaiskazi19 and others added 5 commits December 2, 2025 14:09

Update common/src/main/java/org/opensearch/ml/common/transport/agent/…

42fd876

…MLAgentUpdateInput.java Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Update common/src/main/java/org/opensearch/ml/common/transport/agent/…

47ba27a

…MLAgentUpdateInput.java Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Apply suggestions from code review

ce42231

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Add version import in MLAgentUpdateInput

00e7e7c

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

b4sjoo force-pushed the backport/backport-4341-to-3.3 branch from 468b7cf to 00e7e7c Compare December 2, 2025 22:09

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 22:10 — with GitHub Actions Error

b4sjoo temporarily deployed to ml-commons-cicd-env December 2, 2025 22:10 — with GitHub Actions Inactive

b4sjoo had a problem deploying to ml-commons-cicd-env December 2, 2025 22:10 — with GitHub Actions Failure

ylwu-amzn approved these changes Dec 3, 2025

View reviewed changes

ylwu-amzn merged commit 79626b5 into 3.3 Dec 3, 2025
9 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Backport 3.3] Fix agent type update #4481

[Backport 3.3] Fix agent type update #4481

opensearch-trigger-bot bot commented Dec 2, 2025

Uh oh!

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

owaiskazi19 Dec 2, 2025

Uh oh!

owaiskazi19 Dec 2, 2025

Uh oh!

Uh oh!

Uh oh!

owaiskazi19 commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Backport 3.3] Fix agent type update #4481

[Backport 3.3] Fix agent type update #4481

Conversation

opensearch-trigger-bot bot commented Dec 2, 2025

Uh oh!

coderabbitai bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

owaiskazi19 Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

owaiskazi19 Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

owaiskazi19 commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Dec 2, 2025 •

edited

Loading