Skip to content

Conversation

@nathaliellenaa
Copy link
Contributor

Description

Use filtered output in agent tool response streaming

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nathaliellenaa
Copy link
Contributor Author

Can a maintainer help add backport 3.3 label? Thanks

@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 22, 2025 01:06 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 22, 2025 01:06 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 22, 2025 01:06 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 22, 2025 01:06 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.10%. Comparing base (5964268) to head (b80434f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4335      +/-   ##
============================================
+ Coverage     80.09%   80.10%   +0.01%     
+ Complexity    10199    10197       -2     
============================================
  Files           855      855              
  Lines         44374    44406      +32     
  Branches       5135     5137       +2     
============================================
+ Hits          35540    35573      +33     
- Misses         6670     6672       +2     
+ Partials       2164     2161       -3     
Flag Coverage Δ
ml-commons 80.10% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 22, 2025 18:05 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 22, 2025 18:05 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 24, 2025 16:50 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 24, 2025 16:50 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 24, 2025 16:50 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 24, 2025 16:50 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 27, 2025 21:52 — with GitHub Actions Error
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 04:32 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env-require-approval October 28, 2025 04:32 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env-require-approval October 28, 2025 04:32 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env-require-approval October 28, 2025 04:32 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 06:13 — with GitHub Actions Error
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 06:13 — with GitHub Actions Failure
@nathaliellenaa
Copy link
Contributor Author

Failing test seems unrelated

REPRODUCE WITH: gradlew ':opensearch-ml-plugin:test' --tests 'org.opensearch.ml.utils.IndexUtilsTests.testGetNumberOfDocumentsInIndex_SearchQuery' -Dtests.seed=35FE6356BDC20A38 -Dtests.security.manager=false -Dtests.locale=ff-Latn-NG -Dtests.timezone=America/Cayman -Druntime.java=21
IndexUtilsTests > testGetNumberOfDocumentsInIndex_SearchQuery FAILED
    ClusterManagerNotDiscoveredException[NodeNotConnectedException[[node_s0][127.0.0.1:53838] Node not connected]]; nested: NodeNotConnectedException[[node_s0][127.0.0.1:53838] Node not connected];
        at app//org.opensearch.action.support.clustermanager.TransportClusterManagerNodeAction$AsyncSingleAction$1.onTimeout(TransportClusterManagerNodeAction.java:326)
        at app//org.opensearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:394)
        at app//org.opensearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:294)
        at app//org.opensearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:772)
        at app//org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:916)
        at java.base@21.0.9/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
        at java.base@21.0.9/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
        at java.base@21.0.9/java.lang.Thread.run(Thread.java:1583)

@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 22:04 — with GitHub Actions Error
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 22:04 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 22:04 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 22:04 — with GitHub Actions Error
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 22:06 — with GitHub Actions Error
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 22:06 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 22:06 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 28, 2025 22:06 — with GitHub Actions Error
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 29, 2025 02:32 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 29, 2025 02:32 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 29, 2025 02:32 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 29, 2025 02:32 — with GitHub Actions Failure
@nathaliellenaa
Copy link
Contributor Author

Failing tests due to expired security token

RestMLRAGSearchProcessorIT > testBM25WithBedrockConverseUsingLlmMessagesForDocumentChat FAILED
    org.opensearch.client.ResponseException: method [POST], host [http://[::1]:34197], URI [/test/_search?size=5&search_pipeline=pipeline_test], status line [HTTP/1.1 403 Forbidden]
    {"error":{"root_cause":[{"type":"status_exception","reason":"Error from remote service: {\"message\":\"The security token included in the request is expired\"}"}],"type":"status_exception","reason":"Error from remote service: {\"message\":\"The security token included in the request is expired\"}"},"status":403}

@mingshl mingshl merged commit ec10558 into opensearch-project:main Oct 29, 2025
11 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 29, 2025
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
(cherry picked from commit ec10558)
ylwu-amzn pushed a commit that referenced this pull request Oct 29, 2025
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
(cherry picked from commit ec10558)
pyek-bot pushed a commit that referenced this pull request Oct 29, 2025
(cherry picked from commit ec10558)

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
Co-authored-by: Nathalie Jonathan <143617992+nathaliellenaa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants