-
Notifications
You must be signed in to change notification settings - Fork 186
Upgrade commons-text to fix CVE-2025-48924 #4241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
|
Can you please add the output of dependency insight for this library to see right now which version is it picking up? |
|
Reference PR: #4062 |
It's using the correct one now I tried running the same command without this change (from main branch) and see it's using |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4241 +/- ##
=========================================
Coverage 79.54% 79.54%
Complexity 9690 9690
=========================================
Files 833 833
Lines 43027 43027
Branches 4946 4946
=========================================
Hits 34226 34226
Misses 6715 6715
Partials 2086 2086
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.3 3.3
# Navigate to the new working tree
cd .worktrees/backport-3.3
# Create a new branch
git switch --create backport/backport-4241-to-3.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b5a312f9d5a5776812ab96099ebae548a9d865c7
# Push it to GitHub
git push --set-upstream origin backport/backport-4241-to-3.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.3Then, create a pull request where the |
Description
commons-textversions 1.10.0 - 1.13.0 have a transitive dependency oncommons-lang3< 3.18.0 (ref), which causes this CVE-2025-48924. Upgradingcommons-textto 1.14.0 should fix this issue.Related Issues
Resolves opensearch-project/opensearch-build#5693
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.