-
Notifications
You must be signed in to change notification settings - Fork 186
fixing metrics correlation algorithm #4200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4200 +/- ##
============================================
- Coverage 82.01% 81.93% -0.09%
+ Complexity 9196 9195 -1
============================================
Files 789 789
Lines 39618 39621 +3
Branches 4394 4394
============================================
- Hits 32494 32464 -30
- Misses 5233 5277 +44
+ Partials 1891 1880 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM |
|
thank you for the change Dhrubo! It seems like code coverage failed, lgtm other than that |
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
f1d2dee
Description
[We recently moved our index mapping in json file. That change broke this functionality as model group index wasn't able to be created from the index mapping.
This PR fixes that issue.
]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.