Skip to content

Conversation

@dhrubo-os
Copy link
Collaborator

@dhrubo-os dhrubo-os commented Sep 25, 2025

Description

[We recently moved our index mapping in json file. That change broke this functionality as model group index wasn't able to be created from the index mapping.

This PR fixes that issue.
]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.93%. Comparing base (266bcfe) to head (f1d2dee).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rithms/metrics_correlation/MetricsCorrelation.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4200      +/-   ##
============================================
- Coverage     82.01%   81.93%   -0.09%     
+ Complexity     9196     9195       -1     
============================================
  Files           789      789              
  Lines         39618    39621       +3     
  Branches       4394     4394              
============================================
- Hits          32494    32464      -30     
- Misses         5233     5277      +44     
+ Partials       1891     1880      -11     
Flag Coverage Δ
ml-commons 81.93% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 25, 2025 03:33 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 25, 2025 03:33 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 25, 2025 06:47 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 25, 2025 06:47 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 25, 2025 06:47 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 25, 2025 06:47 — with GitHub Actions Inactive
@xinyual
Copy link
Collaborator

xinyual commented Sep 25, 2025

LGTM

xinyual
xinyual previously approved these changes Sep 25, 2025
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 25, 2025 07:49 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 25, 2025 07:49 — with GitHub Actions Inactive
jackiehanyang
jackiehanyang previously approved these changes Sep 25, 2025
@jackiehanyang
Copy link
Collaborator

thank you for the change Dhrubo! It seems like code coverage failed, lgtm other than that

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os merged commit 7e04653 into opensearch-project:main Sep 26, 2025
9 of 11 checks passed
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 26, 2025 00:43 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 26, 2025 00:43 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants