fix Cohere IT #4174
Merged
fix Cohere IT #4174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinyual <xinyual@amazon.com>
xinyual
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
ylwu-amzn and
zane-neo
as code owners
Signed-off-by: xinyual <xinyual@amazon.com>
xinyual
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
xinyual
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
xinyual
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
xinyual
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4174 +/- ##
============================================
- Coverage 81.91% 81.91% -0.01%
Complexity 8882 8882
============================================
Files 762 762
Lines 38200 38200
Branches 4267 4267
============================================
- Hits 31291 31290 -1
Misses 5080 5080
- Partials 1829 1830 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
previously approved these changes
Sep 17, 2025
Signed-off-by: xinyual <xinyual@amazon.com>
model-collapse
approved these changes
Sep 17, 2025
zane-neo
approved these changes
Sep 17, 2025
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
xinyual
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
5 tasks
brianf-aws
pushed a commit
to brianf-aws/ml-commons
that referenced
this pull request
Oct 27, 2025
* fix Cohere IT Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * delete useless it Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com>
brianf-aws
pushed a commit
to brianf-aws/ml-commons
that referenced
this pull request
Oct 27, 2025
* fix Cohere IT Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * delete useless it Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com> Signed-off-by: Brian Flores <iflorbri@amazon.com>
mingshl
pushed a commit
that referenced
this pull request
Oct 27, 2025
* Increment version to 2.19.4-SNAPSHOT Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Brian Flores <iflorbri@amazon.com> * fix CVE-2025-55163, CVE-2025-48924 (#4298) * address commons-lang3 CVE-2025-48924 Signed-off-by: Brian Flores <iflorbri@amazon.com> * pin netty to 4.2.5.Final version address CVE-2025-55163 Signed-off-by: Brian Flores <iflorbri@amazon.com> * force all subProjects to use updated common-lang3 version Signed-off-by: Brian Flores <iflorbri@amazon.com> --------- Signed-off-by: Brian Flores <iflorbri@amazon.com> * Move HttpClientFactory to common to expose to other components (#4175) * Move HttpClientFactory to common to expose to other componenets Signed-off-by: zane-neo <zaniu@amazon.com> * optimize code for better maintainability Signed-off-by: zane-neo <zaniu@amazon.com> * Optimize code and increase UT coverage Signed-off-by: zane-neo <zaniu@amazon.com> * Address comments Signed-off-by: zane-neo <zaniu@amazon.com> * Use amazon aws version from opensearch core Signed-off-by: zane-neo <zaniu@amazon.com> * address comments Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> Signed-off-by: Brian Flores <iflorbri@amazon.com> * use mainline versions.aws via hardcode Signed-off-by: Brian Flores <iflorbri@amazon.com> * address CVE-2025-58057 Signed-off-by: Brian Flores <iflorbri@amazon.com> * fix code format Signed-off-by: Brian Flores <iflorbri@amazon.com> * empty commit to trigger CI Signed-off-by: Brian Flores <iflorbri@amazon.com> * Fix claude model it (#4167) * fix model it by replace claude v1/v2 Signed-off-by: xinyual <xinyual@amazon.com> * remove useless change Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com> Signed-off-by: Brian Flores <iflorbri@amazon.com> * Don't convert schema-defined strings to other types during validation (#3761) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Brian Flores <iflorbri@amazon.com> * fix Cohere IT (#4174) * fix Cohere IT Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * delete useless it Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com> Signed-off-by: Brian Flores <iflorbri@amazon.com> --------- Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Brian Flores <iflorbri@amazon.com> Signed-off-by: zane-neo <zaniu@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: zane-neo <zaniu@amazon.com> Co-authored-by: Xinyuan Lu <xinyual@amazon.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cohere IT. The
commandmodel is deprecated and the generation API is deprecated.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.