generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 177
[Agentic Memory] Allow other LLMs for Fact Extraction #4159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rithin-pullela-aws
wants to merge
4
commits into
opensearch-project:main
Choose a base branch
from
rithin-pullela-aws:allow-other-llms-agentic-memory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Agentic Memory] Allow other LLMs for Fact Extraction #4159
rithin-pullela-aws
wants to merge
4
commits into
opensearch-project:main
from
rithin-pullela-aws:allow-other-llms-agentic-memory
+779
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolarkunnu
reviewed
Sep 8, 2025
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/memorycontainer/MemoryContainerConstants.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Outdated
Show resolved
Hide resolved
429959f
to
94038e9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4159 +/- ##
=========================================
Coverage 81.89% 81.90%
+ Complexity 8879 8873 -6
=========================================
Files 762 762
Lines 38200 38154 -46
Branches 4267 4256 -11
=========================================
- Hits 31285 31250 -35
+ Misses 5084 5078 -6
+ Partials 1831 1826 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
0482d6c
to
c6cf290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR we expect the users to pass
response_filter
in parameters of the LLM connectors and thus allowing more flexible LLM options for fact extraction in Agentic Memory. This also means we can have a more flexible connector request body without tying to only claude models.To use a Claude model:
To use Open AI models:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.