Skip to content

Conversation

@Zhangxunmt
Copy link
Collaborator

Description

Fix the search query enum serialization errors. The enum cannot be serialized and needs to be converted to String.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Xun Zhang <xunzh@amazon.com>
@dhrubo-os
Copy link
Collaborator

Can we add a unit test for this?

@Zhangxunmt Zhangxunmt merged commit 78f014b into opensearch-project:main Sep 4, 2025
10 checks passed
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.82%. Comparing base (45002a7) to head (ed7264d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/org/opensearch/ml/task/MLTaskManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4158   +/-   ##
=========================================
  Coverage     81.81%   81.82%           
- Complexity     8866     8867    +1     
=========================================
  Files           762      762           
  Lines         38167    38167           
  Branches       4264     4264           
=========================================
+ Hits          31228    31231    +3     
+ Misses         5111     5109    -2     
+ Partials       1828     1827    -1     
Flag Coverage Δ
ml-commons 81.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env September 4, 2025 21:46 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env September 4, 2025 21:46 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants