bug fix #4153
Open
bug fix #4153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubo-os
requested review from
b4sjoo,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman,
xinyual and
pyek-bot
as code owners
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
nitpick, can you try naming the PR fix in a readable title please ? |
mingshl
reviewed
Sep 12, 2025
| } else if (parser.currentToken() == XContentParser.Token.START_OBJECT) { | ||
| memoryEmbedding = parser.map(); // For sparse embeddings | ||
| } else { | ||
| parser.skipChildren(); |
There was a problem hiding this comment.
if other model format, it is quietly skipping, maybe it's better to throw exception when it's not recognized data format. I think this might be the reason why when we used Ollama's model, it went through all the way in setting, but the agentic memory is empty, because here it skips parsing the model output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[bug fix ] #4141
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.