-
Couldn't load subscription status.
- Fork 184
Fix jdt formatter error #4151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jdt formatter error #4151
Conversation
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
|
@nathaliellenaa thanks for your bias for action!! This should solve the issue. From here looks like in every module spotless has the same configuration. Can you please check if we can remove all these and add the spotless configuration in the common build.gradle like here: https://github.com/opensearch-project/ml-commons/blob/main/build.gradle This way we won't need to change in multiple places in future. |
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@dhrubo-os I refactored the spotless configuration into a single common build.gradle file. This change introduced spotless checks to the SPI module (which previously didn't have one), resulting in formatting changes to the files in that module. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4151 +/- ##
============================================
- Coverage 81.82% 81.81% -0.01%
- Complexity 8849 8867 +18
============================================
Files 761 762 +1
Lines 38114 38167 +53
Branches 4251 4264 +13
============================================
+ Hits 31185 31227 +42
- Misses 5109 5113 +4
- Partials 1820 1827 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Fix jdt formatter error and refactor spotless configuration. Issue is due to the external eclipse umd mirror is down.
Following the same changes made in this PR: opensearch-project/OpenSearch#19199
Example of failing workflows:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.