Skip to content

Conversation

@nathaliellenaa
Copy link
Contributor

@nathaliellenaa nathaliellenaa commented Sep 2, 2025

Description

Fix jdt formatter error and refactor spotless configuration. Issue is due to the external eclipse umd mirror is down.

Following the same changes made in this PR: opensearch-project/OpenSearch#19199

Example of failing workflows:

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval September 2, 2025 22:18 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval September 2, 2025 22:18 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval September 2, 2025 22:18 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval September 2, 2025 22:18 — with GitHub Actions Inactive
@dhrubo-os
Copy link
Collaborator

@nathaliellenaa thanks for your bias for action!! This should solve the issue. From here looks like in every module spotless has the same configuration. Can you please check if we can remove all these and add the spotless configuration in the common build.gradle like here: https://github.com/opensearch-project/ml-commons/blob/main/build.gradle

This way we won't need to change in multiple places in future.

pyek-bot
pyek-bot previously approved these changes Sep 2, 2025
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval September 2, 2025 22:45 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval September 2, 2025 22:45 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval September 2, 2025 22:45 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval September 2, 2025 22:45 — with GitHub Actions Inactive
@nathaliellenaa
Copy link
Contributor Author

From here looks like in every module spotless has the same configuration. Can you please check if we can remove all these and add the spotless configuration in the common build.gradle like here: https://github.com/opensearch-project/ml-commons/blob/main/build.gradle

@dhrubo-os I refactored the spotless configuration into a single common build.gradle file. This change introduced spotless checks to the SPI module (which previously didn't have one), resulting in formatting changes to the files in that module.

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.81%. Comparing base (d077f31) to head (815891b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4151      +/-   ##
============================================
- Coverage     81.82%   81.81%   -0.01%     
- Complexity     8849     8867      +18     
============================================
  Files           761      762       +1     
  Lines         38114    38167      +53     
  Branches       4251     4264      +13     
============================================
+ Hits          31185    31227      +42     
- Misses         5109     5113       +4     
- Partials       1820     1827       +7     
Flag Coverage Δ
ml-commons 81.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval September 3, 2025 00:07 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval September 3, 2025 00:07 — with GitHub Actions Error
@pyek-bot pyek-bot merged commit 45002a7 into opensearch-project:main Sep 3, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants