-
Notifications
You must be signed in to change notification settings - Fork 186
Agent/Tool Parsing Fixes #4138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent/Tool Parsing Fixes #4138
Conversation
…jsons Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4138 +/- ##
============================================
+ Coverage 81.81% 81.85% +0.03%
- Complexity 8866 8870 +4
============================================
Files 762 762
Lines 38167 38169 +2
Branches 4264 4266 +2
============================================
+ Hits 31228 31243 +15
+ Misses 5111 5098 -13
Partials 1828 1828
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akolarkunnu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes the following issues:
tool_usebut no tool use block, for this we need to raise a ticket to the bedrock team.,the parsing breaks. This is due to a double conversion of json array to string and string to array. This has been fixed in this PR by directly returning the original json.For more details look at the issues mentioned below
Related Issues
Resolves #4135
Resolves #4137
Partially resolves #4136
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.