code refactoring + add unit test [memory module]

[dhrubo-os]

Description

[code refactoring + add unit test [memory module]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dhrubo-os]

ERROR][o.o.m.e.a.r.MLSdkAsyncHttpResponseHandler] [integTest-0] Received error from remote service with status code 403, response headers: {Connection=[keep-alive], Content-Length=[1829], Content-Type=[application/json], Date=[Mon, 11 Aug 2025 15:36:36 GMT], x-amzn-ErrorType=[InvalidSignatureException:http://internal.amazon.com/coral/com.amazon.coral.service/], x-amzn-RequestId=[c8bd00ff-b0b6-430a-8ccb-6f0e9d977ad1]}
» ERROR][o.o.m.e.a.r.MLSdkAsyncHttpResponseHandler] [integTest-0] Remote service returned error: Error from remote service: {"message":"The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details.\n\nThe Canonical String for this request should have been\n'POST\n/model/anthropic.claude-3-5-sonnet-20240620-v1%3A0/converse\n\ncontent-length:137686\ncontent-type:application/json\nhost:bedrock-runtime.us-west-2.amazonaws.com\nx-amz-date:20250811T153636Z\nx-amz-security-token:***\n\ncontent-length;content-type;host;x-amz-date;x-amz-security-token\nf3f50a7c8135014bda4728d8ed4e8dc142c212589a674633166e33e1f062f355'\n\nThe String-to-Sign should have been\n'AWS4-HMAC-SHA256\n20250811T153636Z\n20250811/us-west-2/bedrock/aws4_request\n80504b1f309ffea64b6496b558cac04cd81f6063d6cae96af7a4b692179e33f3'\n"} with status: FORBIDDEN
» ERROR][o.o.m.e.a.r.MLSdkAsyncHttpResponseHandler] [integTest-0] Received error from remote service with status code 401, response headers: {alt-svc=[h3=":443"; ma=86400], cf-cache-status=[DYNAMIC], CF-RAY=[96d8d13b4e737ab2-SJC], Connection=[keep-alive], Content-Length=[496], Content-Type=[application/json; charset=utf-8], Date=[Mon, 11 Aug 2025 15:37:58 GMT], Server=[cloudflare], Set-Cookie=[__cf_bm=pM3h9ZZBZMi0H8XmcaUtUN5a6AKRMehqFZKTYi4GqGk-1754926678-1.0.1.1-Iaft3dMjoltzfn4Z4oaTgDh1PjAtH4k7ispbWWxXrdaAg2mq3J4GWuioMJP9cYSzWtM0YApULNb5Cba3ojfVxqVKy2d5vQZB903uIfNSVoo; path=/; expires=Mon, 11-Aug-25 16:07:58 GMT; domain=.api.openai.com; HttpOnly; Secure, _cfuvid=JTcSX.Kj71zUlVrrFKEtNlB1e1qnqb0I3bIEXh53t7g-1754926678307-0.0.1.1-604800000; path=/; domain=.api.openai.com; HttpOnly; Secure; SameSite=None], Strict-Transport-Security=[max-age=31536000; includeSubDomains; preload], vary=[Origin], X-Content-Type-Options=[nosniff], x-envoy-upstream-service-time=[0], x-request-id=[req_26db08bd2cd049d5946840005520fa13]}
» ERROR][o.o.m.e.a.r.MLSdkAsyncHttpResponseHandler] [integTest-0] Received error from remote service with status code 401, response headers: {alt-svc=[h3=":443"; ma=86400], cf-cache-status=[DYNAMIC], CF-RAY=[96d8d1bcd95b7ab2-SJC], Connection=[keep-alive], Content-Length=[496], Content-Type=[application/json; charset=utf-8], Date=[Mon, 11 Aug 2025 15:38:19 GMT], Server=[cloudflare], Set-

This is not introduced by this PR.

[rithin-pullela-aws]

Reviewed the business logic files, mostly LGTM apart from very minor nitpicks.
Will review the test files in some time

[rithin-pullela-aws]

nit: can we add @ Getter instead?
same applies for other fields as well

[rithin-pullela-aws]

Should we have itemIndex condition in the for loop since we are anyways skipping the operations id itemIndex is out of bounds

for (int i = 0; i < results.size() && itemIndex < items.length ; i++) {

[rithin-pullela-aws]

Just to understand the underlying design, do we extract facts from a bunch of messages and not a single message from the user?

[rithin-pullela-aws]

Nit: While this is a good way to handle the LLM output parsing, these instructions should be ideally provided in the prompt of the LLM to never output the code blocks. If the current prompt sometimes leads to such outputs, it is an indication that there is a scope of improvement in the prompt

Some resources for prompt optimization from anthropic:

• https://docs.anthropic.com/en/docs/test-and-evaluate/strengthen-guardrails/reduce-hallucinations
• https://docs.anthropic.com/en/docs/test-and-evaluate/strengthen-guardrails/increase-consistency

[codecov]

Codecov Report

❌ Patch coverage is 87.55274% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.89%. Comparing base (8ef3528) to head (81b2399).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...emorycontainer/memory/MemoryProcessingService.java	88.46%	10 Missing and 11 partials ⚠️
...emorycontainer/memory/MemoryOperationsService.java	89.56%	9 Missing and 10 partials ⚠️
...rycontainer/memory/TransportAddMemoriesAction.java	73.17%	10 Missing and 1 partial ⚠️
...on/memorycontainer/memory/MemorySearchService.java	90.47%	3 Missing and 1 partial ⚠️
...h/ml/action/memorycontainer/memory/MemoryInfo.java	83.33%	2 Missing ⚠️
...rg/opensearch/ml/helper/MemoryEmbeddingHelper.java	71.42%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4086      +/-   ##
============================================
+ Coverage     79.06%   80.89%   +1.82%     
- Complexity     8621     8727     +106     
============================================
  Files           755      760       +5     
  Lines         38352    38090     -262     
  Branches       4287     4245      -42     
============================================
+ Hits          30324    30813     +489     
+ Misses         6220     5442     -778     
- Partials       1808     1835      +27     

Flag	Coverage Δ
ml-commons	80.89% <87.55%> (+1.82%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dhrubo-os]

@rithin-pullela-aws I'll address all your comment in the next followup. Merging to unblock @b4sjoo