generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 186
Support output filter, unify tool parameter handling and improve Sear… #4053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyek-bot
approved these changes
Aug 5, 2025
Collaborator
pyek-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Collaborator
Author
|
Security token expried |
…chIndexTool output parsing Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
dhrubo-os
approved these changes
Aug 6, 2025
b4sjoo
approved these changes
Aug 6, 2025
5 tasks
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…chIndexTool output parsing
Description
Fix issues when build Agentic RAG with automatic index selection tutorial
In the tutorial, the Chat Agent uses AgentTool to call another Flow Agent. The flow agent generates OpenSearch query and search index. The Flow Agent returns extra info, but we only need the query response part. So we need tool output filter.
The Flow Agent will pass the generated OpenSearch query to SearchIndexTool to search data. But the escape is wrong. The query is already valid json. If we run
escapeJson(outputResponse)again, the query json string become invalid.In this tutorial, we use one LLM which has multiple placeholders like
_chat_history,tool_configs. The root Chat Agent is Chat Agent, which has chat history and tool configs in parameters. When Chat Agent run the Flow Agent through a tool call, it will also pass these parameters to Flow Agent. Since Flow Agent use same LLM, these parameter will cause wrong result in Flow Agent. So we need to support required parameter on tool level to filter out only the required parameters.SearchIndexTool always returns the search hits part. But for an aggregation query, the search hits part is empty. Add a new parameter to return the full response.
For example
Response
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.