-
Notifications
You must be signed in to change notification settings - Fork 186
Add Default System Prompt for the query Planner tool #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Default System Prompt for the query Planner tool #4046
Conversation
b2de23a to
e8bf212
Compare
|
Is this ready for review? |
Not yet, I need to collect feedback from @mingshl and @owaiskazi19. Will mark it as ready once it is ready |
ml-algorithms/src/main/java/org/opensearch/ml/engine/tools/QueryPlanningTool.java
Show resolved
Hide resolved
e8bf212 to
e9266f6
Compare
e9266f6 to
7bf3b71
Compare
|
@xinyual |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4046 +/- ##
=========================================
Coverage 80.93% 80.94%
- Complexity 8256 8258 +2
=========================================
Files 712 713 +1
Lines 35960 35963 +3
Branches 4040 4042 +2
=========================================
+ Hits 29106 29111 +5
+ Misses 5086 5083 -3
- Partials 1768 1769 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
691dbf3 to
17a0f7a
Compare
a9be8b3 to
7bed940
Compare
mingshl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In the next PR, please provide some evaluation data to show improvements on the default prompt performances.
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
…ryPlanningPromptTemplate.java Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Rithin Pullela <rithinp@amazon.com>
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
7bed940 to
d3350e6
Compare
Description
This change adds a default system prompt to the query planner tool
Create Model:
Response:
The Default System Prompt:
Related Issues
Resolves #4005
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.