Skip to content

Add feature flag for agentic search #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 6, 2025
Merged

Add feature flag for agentic search #4021

merged 8 commits into from
Aug 6, 2025

Conversation

@rithin-pullela-aws
Copy link
Contributor

@rithin-pullela-aws rithin-pullela-aws commented Jul 31, 2025 •
edited by mingshl
Loading

Description

Add the feature flag plugins.ml_commons.mcp_connector_enabled defaulted to false for agentic search feature.

Prevent registering and executing agents with queryPlannerTool.

Related Issues

Resolves #4005

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rithin-pullela-aws rithin-pullela-aws force-pushed the agentic-search-feature-flag branch from 33773f4 to e7a24eb Compare July 31, 2025 06:40
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval July 31, 2025 06:41 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval July 31, 2025 06:41 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval July 31, 2025 06:41 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval July 31, 2025 06:41 — with GitHub Actions Failure
mingshl
mingshl reviewed Jul 31, 2025
View reviewed changes
ml-algorithms/src/main/java/org/opensearch/ml/engine/algorithms/agent/MLAgentExecutor.java
listener.onFailure(new OpenSearchException(ML_COMMONS_MCP_CONNECTOR_DISABLED_MESSAGE));
return;
}
List<MLToolSpec> tools = mlAgent.getTools();
Copy link
Collaborator

@mingshl mingshl Jul 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. If we can block users from registerAgent with QueryPlanningTool that would be more user-friendly, or we would waste users' attempting in registering the agent with QueryPlanningTool then execute and find out it's not supported in this version.

@rithin-pullela-aws rithin-pullela-aws force-pushed the agentic-search-feature-flag branch from e7a24eb to e6464ed Compare August 1, 2025 03:24
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 1, 2025 03:26 — with GitHub Actions Error
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 1, 2025 03:26 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 1, 2025 03:26 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 1, 2025 03:26 — with GitHub Actions Error
@dhrubo-os dhrubo-os had a problem deploying to ml-commons-cicd-env-require-approval August 2, 2025 19:13 — with GitHub Actions Error
@dhrubo-os dhrubo-os had a problem deploying to ml-commons-cicd-env-require-approval August 2, 2025 19:13 — with GitHub Actions Failure
@dhrubo-os dhrubo-os had a problem deploying to ml-commons-cicd-env-require-approval August 2, 2025 19:13 — with GitHub Actions Error
@dhrubo-os dhrubo-os had a problem deploying to ml-commons-cicd-env-require-approval August 2, 2025 19:13 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws force-pushed the agentic-search-feature-flag branch from 2d4c849 to cf64838 Compare August 3, 2025 21:04
@rithin-pullela-aws rithin-pullela-aws marked this pull request as ready for review August 3, 2025 21:04
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 3, 2025 21:05 — with GitHub Actions Error
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 3, 2025 21:05 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws force-pushed the agentic-search-feature-flag branch from 460be5d to 7cfa4df Compare August 5, 2025 19:44
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 5, 2025 19:47 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 5, 2025 19:47 — with GitHub Actions Error
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 5, 2025 19:47 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 5, 2025 19:47 — with GitHub Actions Error
@rithin-pullela-aws rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval August 5, 2025 22:43 — with GitHub Actions Inactive
@rithin-pullela-aws rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval August 5, 2025 22:43 — with GitHub Actions Inactive
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 5, 2025 22:44 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval August 5, 2025 22:44 — with GitHub Actions Inactive
@mingshl
Copy link
Collaborator

mingshl commented Aug 5, 2025

waiting on CI to pass

@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Aug 5, 2025

@rithin-pullela-aws you need to resolve the conflict here

@rithin-pullela-aws
Add feature flag for agentic search
5bc51d2 
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws
Address edge case and comments
a5a292f 
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws
Use MLFeatureEnabled Settings
c96c5c5 
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws
Fix failing tests
b002dcb 
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws
Prevent qp tool create when not enabled
f651212 
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws
Fix failing test
3c5efee 
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws
Fix failing tests
d6b08bb 
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws
Add UTs
d882441 
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@rithin-pullela-aws rithin-pullela-aws force-pushed the agentic-search-feature-flag branch from 7e625a4 to d882441 Compare August 6, 2025 00:16
@rithin-pullela-aws rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval August 6, 2025 00:17 — with GitHub Actions Inactive
@rithin-pullela-aws rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval August 6, 2025 00:17 — with GitHub Actions Inactive
@rithin-pullela-aws rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval August 6, 2025 00:17 — with GitHub Actions Inactive
@rithin-pullela-aws rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval August 6, 2025 00:17 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt merged commit 145f9f8 into opensearch-project:main Aug 6, 2025
9 checks passed
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 6, 2025 01:26 — with GitHub Actions Failure
@rithin-pullela-aws rithin-pullela-aws had a problem deploying to ml-commons-cicd-env-require-approval August 6, 2025 01:26 — with GitHub Actions Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mingshl mingshl mingshl left review comments

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@pyek-bot pyek-bot pyek-bot approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

+1 more reviewer

@nathaliellenaa nathaliellenaa nathaliellenaa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC] Agentic Search in OpenSearch

6 participants

@rithin-pullela-aws @pyek-bot @mingshl @dhrubo-os @Zhangxunmt @nathaliellenaa