Skip to content

Bump gradle to 8.14 and update JDK to 24 #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2025

Conversation

pyek-bot
Copy link
Contributor

@pyek-bot pyek-bot commented Jul 16, 2025

Description

Update gradle to 8.14 version and JDK from 23 to 24

Dependencies:
com.netflix.nebula.ospackage-base from 11.5.0 to 12.0.0

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval July 16, 2025 19:08 — with GitHub Actions Inactive
@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval July 16, 2025 19:08 — with GitHub Actions Error
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval July 16, 2025 19:08 — with GitHub Actions Inactive
@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval July 16, 2025 19:08 — with GitHub Actions Failure
@brianf-aws
Copy link
Contributor

@pyek-bot do we need to change the github CI? Im wondering how it will affect it

@pyek-bot
Copy link
Contributor Author

@pyek-bot do we need to change the github CI? Im wondering how it will affect it

It's a requirement from infra team. Example from knn: https://github.com/opensearch-project/k-NN/pull/2792/files

@dhrubo-os dhrubo-os had a problem deploying to ml-commons-cicd-env-require-approval July 21, 2025 21:23 — with GitHub Actions Failure
@dhrubo-os dhrubo-os had a problem deploying to ml-commons-cicd-env-require-approval July 21, 2025 21:23 — with GitHub Actions Error
@dhrubo-os dhrubo-os had a problem deploying to ml-commons-cicd-env-require-approval July 21, 2025 21:23 — with GitHub Actions Failure
@dhrubo-os dhrubo-os had a problem deploying to ml-commons-cicd-env-require-approval July 21, 2025 21:23 — with GitHub Actions Error
@dhrubo-os dhrubo-os requested a deployment to ml-commons-cicd-env-require-approval July 29, 2025 22:20 — with GitHub Actions Waiting
@dhrubo-os dhrubo-os requested a deployment to ml-commons-cicd-env-require-approval July 29, 2025 22:20 — with GitHub Actions Waiting
@dhrubo-os dhrubo-os requested a deployment to ml-commons-cicd-env-require-approval July 29, 2025 22:20 — with GitHub Actions Waiting
@dhrubo-os dhrubo-os requested a deployment to ml-commons-cicd-env-require-approval July 29, 2025 22:20 — with GitHub Actions Waiting
@dhrubo-os
Copy link
Collaborator

@pyek-bot do we need this PR as a part of 3.2 release? I saw some integ test issue. Have you tried in your end to run integ test?

@pyek-bot
Copy link
Contributor Author

@pyek-bot do we need this PR as a part of 3.2 release? I saw some integ test issue. Have you tried in your end to run integ test?

Yes, previous error seems to be tag mismatch:

Caused by: org.opensearch.core.common.io.stream.NotSerializableExceptionWrapper: a_e_a_d_bad_tag_exception: Tag mismatch
»  	at com.sun.crypto.provider.GaloisCounterMode$GCMDecrypt.doFinal(GaloisCounterMode.java:1545) ~[?:?]
»  	at com.sun.crypto.provider.GaloisCounterMode.engineDoFinal(GaloisCounterMode.java:417) ~[?:?]
»  	at javax.crypto.Cipher.doFinal(Cipher.java:2244) ~[?:?]
»  	at com.amazonaws.encryptionsdk.internal.JceKeyCipher.decryptKey(JceKeyCipher.java:129) ~[?:?]
»  	at com.amazonaws.encryptionsdk.jce.JceMasterKey.decryptDataKey(JceMasterKey.java:165) ~[?:?]
»  	at com.amazonaws.encryptionsdk.DefaultCryptoMaterialsManager.decryptMaterials(DefaultCryptoMaterialsManager.java:118) ~[?:?]
»  	at com.amazonaws.encryptionsdk.internal.DecryptionHandler.readHeaderFields(DecryptionHandler.java:621) ~[?:?]
»  	at com.amazonaws.encryptionsdk.internal.DecryptionHandler.<init>(DecryptionHandler.java:111) ~[?:?]
»  	at com.amazonaws.encryptionsdk.internal.DecryptionHandler.create(DecryptionHandler.java:302) ~[?:?]
»  	at com.amazonaws.encryptionsdk.AwsCrypto.decryptData(AwsCrypto.java:511) ~[?:?]
»  	at com.amazonaws.encryptionsdk.AwsCrypto.decryptData(AwsCrypto.java:502) ~[?:?]
»  	at com.amazonaws.encryptionsdk.AwsCrypto.decryptData(AwsCrypto.java:476) ~[?:?]
»  	at org.opensearch.ml.engine.encryptor.EncryptorImpl.decrypt(EncryptorImpl.java:113) ~[?:?]
»  	at org.opensearch.ml.engine.algorithms.remote.RemoteModel.lambda$initModel$0(RemoteModel.java:105) ~[?:?]
»  	at org.opensearch.ml.common.connector.HttpConnector.decrypt(HttpConnector.java:388) ~[?:?]
»  	at org.opensearch.ml.engine.algorithms.remote.RemoteModel.initModel(RemoteModel.java:105) ~[?:?]
»  	at org.opensearch.ml.engine.MLEngine.deploy(MLEngine.java:149) ~[?:?]
»  	at org.opensearch.ml.model.MLModelManager.setupParamsAndPredictable(MLModelManager.java:1465) ~[?:?]

@dhrubo-os can you help re-trigger the build? I will monitor it

Signed-off-by: Pavan Yekbote <pybot@amazon.com>
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval July 30, 2025 18:21 — with GitHub Actions Inactive
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval July 30, 2025 18:21 — with GitHub Actions Inactive
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval July 30, 2025 18:21 — with GitHub Actions Inactive
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval July 30, 2025 18:21 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.62%. Comparing base (7040e8a) to head (d06357e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3983   +/-   ##
=========================================
  Coverage     80.62%   80.62%           
- Complexity     8003     8007    +4     
=========================================
  Files           695      695           
  Lines         35023    35023           
  Branches       3935     3935           
=========================================
+ Hits          28236    28239    +3     
+ Misses         5051     5048    -3     
  Partials       1736     1736           
Flag Coverage Δ
ml-commons 80.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval July 30, 2025 19:25 — with GitHub Actions Inactive
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval July 30, 2025 19:25 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit 7eb0d80 into opensearch-project:main Jul 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants