generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 186
properly handles commons-beanutils to 1.11.0 fixes CVE-48734 #3925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Flores <iflorbri@amazon.com>
tested locally with ./gradlew :opensearch-ml-algorithms:dependencyInsight --dependency commons-beanutils --configuration runtimeClasspath Signed-off-by: Brian Flores <iflorbri@amazon.com>
Zhangxunmt
previously approved these changes
Jun 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3925 +/- ##
============================================
- Coverage 80.39% 80.36% -0.04%
- Complexity 7909 7915 +6
============================================
Files 693 693
Lines 34851 34864 +13
Branches 3872 3878 +6
============================================
- Hits 28020 28019 -1
- Misses 5096 5105 +9
- Partials 1735 1740 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jngz-es
previously approved these changes
Jun 19, 2025
mingshl
previously approved these changes
Jun 19, 2025
Signed-off-by: Brian Flores <iflorbri@amazon.com>
23afd3b
mingshl
approved these changes
Jun 19, 2025
jngz-es
approved these changes
Jun 19, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
* force beanUtils to 2.0 Signed-off-by: Brian Flores <iflorbri@amazon.com> * properly handles commons-beanutils to 1.11.0 tested locally with ./gradlew :opensearch-ml-algorithms:dependencyInsight --dependency commons-beanutils --configuration runtimeClasspath Signed-off-by: Brian Flores <iflorbri@amazon.com> --------- Signed-off-by: Brian Flores <iflorbri@amazon.com> (cherry picked from commit d47ba65)
jngz-es
pushed a commit
that referenced
this pull request
Jun 19, 2025
…3928) * force beanUtils to 2.0 * properly handles commons-beanutils to 1.11.0 tested locally with ./gradlew :opensearch-ml-algorithms:dependencyInsight --dependency commons-beanutils --configuration runtimeClasspath --------- (cherry picked from commit d47ba65) Signed-off-by: Brian Flores <iflorbri@amazon.com> Co-authored-by: Brian Flores <iflorbri@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the previous PR (#3915) didnt convert the dependency to a different version. This PR does
I'm borrowing from https://github.com/opensearch-project/query-insights/pull/370/files I tested locally to see before and after this time.
Related Issues
Solves #3915 properly
Testing
You can see the dependency is now
commons-beanutils:commons-beanutils:1.9.4 -> 1.11.0The previous Pr did
But when you check with :opensearch-ml-algorithms:dependencyInsight
it shows up as commons-beanutils:commons-beanutils:1.9.4
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.