Skip to content

Conversation

@brianf-aws
Copy link
Contributor

Description

the previous PR (#3915) didnt convert the dependency to a different version. This PR does

I'm borrowing from https://github.com/opensearch-project/query-insights/pull/370/files I tested locally to see before and after this time.

Related Issues

Solves #3915 properly

Testing

You can see the dependency is now commons-beanutils:commons-beanutils:1.9.4 -> 1.11.0

 ./gradlew :opensearch-ml-algorithms:dependencyInsight \
    --dependency commons-beanutils \
    --configuration runtimeClasspath

=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.11.1
  OS Info               : Mac OS X 15.5 (aarch64)
  JDK Version           : 21 (Amazon Corretto JDK)
  JAVA_HOME             : /Users/iflorbri/.sdkman/candidates/java/21.0.5-amzn
  Random Testing Seed   : 2158C0CF9FB74BA9
  Crypto Standard       : any-supported
=======================================

> Task :opensearch-ml-algorithms:dependencyInsight
commons-beanutils:commons-beanutils:1.11.0 (selected by rule)
  Variant runtime:
    | Attribute Name                 | Provided     | Requested    |
    |--------------------------------|--------------|--------------|
    | org.gradle.status              | release      |              |
    | org.gradle.category            | library      | library      |
    | org.gradle.libraryelements     | jar          | jar          |
    | org.gradle.usage               | java-runtime | java-runtime |
    | org.gradle.dependency.bundling |              | external     |
    | org.gradle.jvm.environment     |              | standard-jvm |
    | org.gradle.jvm.version         |              | 21           |

commons-beanutils:commons-beanutils:1.9.4 -> 1.11.0
\--- com.opencsv:opencsv:5.4
     \--- org.tribuo:tribuo-data:4.2.1
          +--- org.tribuo:tribuo-clustering-kmeans:4.2.1
          |    \--- runtimeClasspath
          +--- org.tribuo:tribuo-regression-sgd:4.2.1
          |    \--- runtimeClasspath
          +--- org.tribuo:tribuo-classification-sgd:4.2.1
          |    \--- runtimeClasspath
          +--- org.tribuo:tribuo-common-sgd:4.2.1
          |    +--- org.tribuo:tribuo-regression-sgd:4.2.1 (*)
          |    \--- org.tribuo:tribuo-classification-sgd:4.2.1 (*)
          +--- org.tribuo:tribuo-anomaly-core:4.2.1
          |    \--- org.tribuo:tribuo-anomaly-libsvm:4.2.1
          |         \--- runtimeClasspath
          \--- org.tribuo:tribuo-common-tree:4.2.1
               \--- org.tribuo:tribuo-classification-core:4.2.1
                    \--- org.tribuo:tribuo-classification-sgd:4.2.1 (*)

The previous Pr did

    resolutionStrategy.force 'org.apache.commons:commons-beanutils:2.0.0'

But when you check with :opensearch-ml-algorithms:dependencyInsight
it shows up as commons-beanutils:commons-beanutils:1.9.4

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Brian Flores <iflorbri@amazon.com>
tested locally with  ./gradlew :opensearch-ml-algorithms:dependencyInsight --dependency commons-beanutils --configuration runtimeClasspath

Signed-off-by: Brian Flores <iflorbri@amazon.com>
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 00:50 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 00:50 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 00:50 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 00:50 — with GitHub Actions Inactive
Zhangxunmt
Zhangxunmt previously approved these changes Jun 19, 2025
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.36%. Comparing base (3453171) to head (23afd3b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3925      +/-   ##
============================================
- Coverage     80.39%   80.36%   -0.04%     
- Complexity     7909     7915       +6     
============================================
  Files           693      693              
  Lines         34851    34864      +13     
  Branches       3872     3878       +6     
============================================
- Hits          28020    28019       -1     
- Misses         5096     5105       +9     
- Partials       1735     1740       +5     
Flag Coverage Δ
ml-commons 80.36% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 01:58 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 01:58 — with GitHub Actions Inactive
jngz-es
jngz-es previously approved these changes Jun 19, 2025
mingshl
mingshl previously approved these changes Jun 19, 2025
Signed-off-by: Brian Flores <iflorbri@amazon.com>
@brianf-aws brianf-aws dismissed stale reviews from mingshl, jngz-es, and Zhangxunmt via 23afd3b June 19, 2025 04:42
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 04:44 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 04:44 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 04:44 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 04:44 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 16:55 — with GitHub Actions Inactive
@brianf-aws brianf-aws temporarily deployed to ml-commons-cicd-env-require-approval June 19, 2025 16:55 — with GitHub Actions Inactive
@jngz-es jngz-es merged commit d47ba65 into opensearch-project:main Jun 19, 2025
12 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 19, 2025
* force beanUtils to 2.0

Signed-off-by: Brian Flores <iflorbri@amazon.com>

* properly handles commons-beanutils to 1.11.0

tested locally with  ./gradlew :opensearch-ml-algorithms:dependencyInsight --dependency commons-beanutils --configuration runtimeClasspath

Signed-off-by: Brian Flores <iflorbri@amazon.com>

---------

Signed-off-by: Brian Flores <iflorbri@amazon.com>
(cherry picked from commit d47ba65)
jngz-es pushed a commit that referenced this pull request Jun 19, 2025
…3928)

* force beanUtils to 2.0



* properly handles commons-beanutils to 1.11.0

tested locally with  ./gradlew :opensearch-ml-algorithms:dependencyInsight --dependency commons-beanutils --configuration runtimeClasspath



---------


(cherry picked from commit d47ba65)

Signed-off-by: Brian Flores <iflorbri@amazon.com>
Co-authored-by: Brian Flores <iflorbri@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants