-
Couldn't load subscription status.
- Fork 184
Allow unix domain socket for loopback calls on windows #3729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow unix domain socket for loopback calls on windows #3729
Conversation
|
@peterzhuamazon could you please review. For Skills plugin which is broken in lack of this permission, do we need to first include this change into min distribution? |
Signed-off-by: Gulshan <kumargu@amazon.com>
a30fb9f to
dfef69c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3729 +/- ##
============================================
- Coverage 79.11% 79.10% -0.01%
+ Complexity 7116 7115 -1
============================================
Files 623 623
Lines 31590 31590
Branches 3574 3574
============================================
- Hits 24993 24990 -3
- Misses 5057 5058 +1
- Partials 1540 1542 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nsearch-project#3729) Signed-off-by: Gulshan <kumargu@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Description
With Java agent as a replacement to security manager, we start enforcing access to UnixDomainSockets. On windows since UnixDomainSockets are used for loopback address windows builds are now starting to fail for opensearch-project/skills#551 and opensearch-project/flow-framework#1105.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.