Skip to content

Conversation

@kumargu
Copy link
Contributor

@kumargu kumargu commented Apr 13, 2025

Description

With Java agent as a replacement to security manager, we start enforcing access to UnixDomainSockets. On windows since UnixDomainSockets are used for loopback address windows builds are now starting to fail for opensearch-project/skills#551 and opensearch-project/flow-framework#1105.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kumargu kumargu had a problem deploying to ml-commons-cicd-env-require-approval April 13, 2025 18:12 — with GitHub Actions Error
@kumargu kumargu had a problem deploying to ml-commons-cicd-env-require-approval April 13, 2025 18:12 — with GitHub Actions Failure
@kumargu kumargu had a problem deploying to ml-commons-cicd-env-require-approval April 13, 2025 18:12 — with GitHub Actions Error
@kumargu kumargu had a problem deploying to ml-commons-cicd-env-require-approval April 13, 2025 18:12 — with GitHub Actions Failure
@kumargu
Copy link
Contributor Author

kumargu commented Apr 13, 2025

@peterzhuamazon could you please review. For Skills plugin which is broken in lack of this permission, do we need to first include this change into min distribution?

Signed-off-by: Gulshan <kumargu@amazon.com>
@kumargu kumargu force-pushed the policy_for_java_agent branch from a30fb9f to dfef69c Compare April 14, 2025 15:28
@kumargu kumargu temporarily deployed to ml-commons-cicd-env-require-approval April 14, 2025 15:30 — with GitHub Actions Inactive
@kumargu kumargu temporarily deployed to ml-commons-cicd-env-require-approval April 14, 2025 15:30 — with GitHub Actions Inactive
@kumargu kumargu temporarily deployed to ml-commons-cicd-env-require-approval April 14, 2025 15:30 — with GitHub Actions Inactive
@kumargu kumargu temporarily deployed to ml-commons-cicd-env-require-approval April 14, 2025 15:30 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (f9edbb0) to head (dfef69c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3729      +/-   ##
============================================
- Coverage     79.11%   79.10%   -0.01%     
+ Complexity     7116     7115       -1     
============================================
  Files           623      623              
  Lines         31590    31590              
  Branches       3574     3574              
============================================
- Hits          24993    24990       -3     
- Misses         5057     5058       +1     
- Partials       1540     1542       +2     
Flag Coverage Δ
ml-commons 79.10% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kumargu kumargu temporarily deployed to ml-commons-cicd-env-require-approval April 14, 2025 16:44 — with GitHub Actions Inactive
@kumargu kumargu temporarily deployed to ml-commons-cicd-env-require-approval April 14, 2025 16:44 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit b7e6c20 into opensearch-project:main Apr 14, 2025
12 of 13 checks passed
@kumargu kumargu deleted the policy_for_java_agent branch April 14, 2025 17:36
akolarkunnu pushed a commit to akolarkunnu/ml-commons that referenced this pull request Jun 6, 2025
…nsearch-project#3729)

Signed-off-by: Gulshan <kumargu@amazon.com>
Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants