Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back Mingshi as Maintainer. #3367

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

dhrubo-os
Copy link
Collaborator

Description

[Adding back Mingshi as Maintainer.]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env January 10, 2025 20:25 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit f8f79c9 into opensearch-project:main Jan 10, 2025
11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3367-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f8f79c9bc7a094673a20aa60e6af12e983ce7c8b
# Push it to GitHub
git push --set-upstream origin backport/backport-3367-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3367-to-2.x.

dhrubo-os added a commit to dhrubo-os/ml-commons that referenced this pull request Jan 10, 2025
* adding more log to debug the testVisualizationFound issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* changing back

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* adding mingshi as maintainer

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
dhrubo-os added a commit to dhrubo-os/ml-commons that referenced this pull request Jan 10, 2025
* adding more log to debug the testVisualizationFound issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* changing back

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* adding mingshi as maintainer

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
dhrubo-os added a commit that referenced this pull request Jan 10, 2025
* adding more log to debug the testVisualizationFound issue



* changing back



* adding mingshi as maintainer



---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x documentation Improvements or additions to documentation infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants