Add application_type to ConversationMeta; update tests #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithin-pullela-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
rithin-pullela-aws
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
rithin-pullela-aws
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Modify getMemory(Conversation) to return the application_type parameter. Include application_type in the ConversationMeta data model. Update existing tests to validate the new parameter. Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
rithin-pullela-aws
force-pushed
the
getConversation
branch
from
a841543 to
3a46832
Compare
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
reviewed
Dec 18, 2024
common/src/main/java/org/opensearch/ml/common/conversation/ConversationMeta.java
Show resolved
Hide resolved
pyek-bot
reviewed
Dec 18, 2024
common/src/main/java/org/opensearch/ml/common/conversation/ConversationMeta.java
Show resolved
Hide resolved
pyek-bot
reviewed
Dec 18, 2024
common/src/main/java/org/opensearch/ml/common/conversation/ConversationMeta.java
Show resolved
Hide resolved
mingshl
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Thanks @rithin-pullela-aws for making the quick fix. Somehow this application_type was left out in the past version. This is a good find!
|
I added the backport label to 2.x branch, please double check which version this bug was left out and please add the backport version all to ways back to the version when this bug is introduced. |
dhrubo-os
approved these changes
Dec 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
Modify getMemory(Conversation) to return the application_type parameter. Include application_type in the ConversationMeta data model. Update existing tests to validate the new parameter. Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> (cherry picked from commit d09374c)
tkykenmt
pushed a commit
to tkykenmt/ml-commons
that referenced
this pull request
Dec 25, 2024
…oject#3282) Modify getMemory(Conversation) to return the application_type parameter. Include application_type in the ConversationMeta data model. Update existing tests to validate the new parameter. Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
this seems be left for intention, cc @Zhangxunmt @ylwu-amzn |
can you elaborate the reason please? |
rithin-pullela-aws
added a commit
to rithin-pullela-aws/ml-commons
that referenced
this pull request
Dec 31, 2024
…earch-project#3282)" This reverts commit d09374c.
rithin-pullela-aws
added a commit
to rithin-pullela-aws/ml-commons
that referenced
this pull request
Dec 31, 2024
…earch-project#3282)" This reverts commit d09374c. Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
ylwu-amzn
pushed a commit
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify getMemory(Conversation) to return the application_type parameter. Include application_type in the ConversationMeta data model. Update existing tests to validate the new parameter.
Description
Add application_type in conversation meta and make other parts of code compatible to this new parameter
Related Issues
Resolves #3279
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.