[Refactor] Remove bloat due to unnecessary setup in test and add retry for potential flaky behavior due to timeout #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
pyek-bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
Zhangxunmt
reviewed
Dec 6, 2024
plugin/src/test/java/org/opensearch/ml/action/models/GetModelITTests.java
Show resolved
Hide resolved
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
Zhangxunmt
approved these changes
Dec 6, 2024
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dhrubo-os
approved these changes
Dec 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…y for potential flaky behavior due to timeout (#3259) * refactor: add retries and remove bloat Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: adding return for valid inputs to prevent multiple runs Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> --------- Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> (cherry picked from commit 8eea6dc)
tkykenmt
pushed a commit
to tkykenmt/ml-commons
that referenced
this pull request
Dec 15, 2024
…y for potential flaky behavior due to timeout (opensearch-project#3259) * refactor: add retries and remove bloat Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: adding return for valid inputs to prevent multiple runs Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> --------- Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
tkykenmt
pushed a commit
to tkykenmt/ml-commons
that referenced
this pull request
Dec 15, 2024
…y for potential flaky behavior due to timeout (opensearch-project#3259) * refactor: add retries and remove bloat Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: adding return for valid inputs to prevent multiple runs Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> --------- Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> Signed-off-by: tkykenmt <tkykenmto+github.com@gmail.com>
ylwu-amzn
pushed a commit
that referenced
this pull request
Jan 3, 2025
…y for potential flaky behavior due to timeout (#3259) (#3265) * refactor: add retries and remove bloat Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: adding return for valid inputs to prevent multiple runs Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> --------- Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> (cherry picked from commit 8eea6dc) Co-authored-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExpectedException::exceptI was not able to determine a failing workflow due to this test. However, I believe the cause of this might be due to the timeout. We can monitor future workflows and check if this particular test fails again.
Additionally, I have unignored a previously ignored test. Please let me know if that is okay. @b4sjoo
It was ignored in this PR: #928
Related Issues
Resolves #3256
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.