getFirst is not allowed in java 17 #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
dhrubo-os
requested review from
b4sjoo,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
approved these changes
Nov 18, 2024
rbhavna
approved these changes
Nov 18, 2024
pyek-bot
reviewed
Nov 18, 2024
| @@ -41,7 +42,7 @@ public RemoteInferenceInputDataSet process(MLInput mlInput) { | |||
| * connector.pre_process.cohere.embedding | |||
| * Cohere expects An array of image data URIs for the model to embed. Maximum number of images per call is 1. | |||
| */ | |||
| parametersMap.put("images", inputData.getDocs().getFirst()); | |||
| parametersMap.put("images", inputData.getDocs().get(0)); | |||
There was a problem hiding this comment.
can docs here be empty or null?
There was a problem hiding this comment.
Seems already validate by L28?
There was a problem hiding this comment.
Seems already validate by L28?
Yup
There was a problem hiding this comment.
yeah, it is also handled in the constructor here:
@Builder(toBuilder = true)
public TextDocsInputDataSet(List<String> docs, ModelResultFilter resultFilter) {
super(MLInputDataType.TEXT_DOCS);
this.resultFilter = resultFilter;
Objects.requireNonNull(docs);
if (docs.size() == 0) {
throw new IllegalArgumentException("empty docs");
}
this.docs = docs;
}
pyek-bot
approved these changes
Nov 18, 2024
b4sjoo
approved these changes
Nov 18, 2024
|
Was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[getFirst is not allowed in java 17]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.