Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial search request inference processor #2616

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Add initial search request inference processor #2616

merged 3 commits into from
Jul 24, 2024

Conversation

mingshl
Copy link
Collaborator

@mingshl mingshl commented Jul 8, 2024 •
edited
Loading

Description

Add initial search request inference processor

Issues Resolved

#2173
#2444

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mingshl
add initial search request inference processor
48dbdf2 
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@mingshl mingshl had a problem deploying to ml-commons-cicd-env July 8, 2024 06:51 — with GitHub Actions Failure
@mingshl mingshl had a problem deploying to ml-commons-cicd-env July 8, 2024 06:51 — with GitHub Actions Failure
@mingshl mingshl had a problem deploying to ml-commons-cicd-env July 8, 2024 15:55 — with GitHub Actions Failure
@mingshl mingshl had a problem deploying to ml-commons-cicd-env July 8, 2024 15:55 — with GitHub Actions Failure
This was referenced Jul 12, 2024
Closed
Open
@mingshl
Add ITs for MLInferenceSearchRequestProcessor
037d2fc 
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@mingshl mingshl marked this pull request as ready for review July 17, 2024 07:02
@mingshl
skip running OPENAI when key is not present and fix yaml test issue
1cb0f58 
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@mingshl mingshl force-pushed the add-inference-search-request-processor-draft branch from 50afa89 to 1cb0f58 Compare July 18, 2024 04:27
@mingshl mingshl temporarily deployed to ml-commons-cicd-env July 18, 2024 04:28 — with GitHub Actions Inactive
@mingshl
Copy link
Collaborator Author

mingshl commented Jul 22, 2024 •
edited
Loading

Build on linux failed by the flaky test not related to this code change, rerunning linux test

REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.rest.RestMLDeployModelActionIT.testReDeployModel" -Dtests.seed=7FCA7B5A34B9F0A0 -Dtests.security.manager=false -Dtests.locale=en-TV -Dtests.timezone=Etc/GMT-4 -Druntime.java=21
    	at java.base@21.0.4/java.lang.Thread.run(Thread.java:1583)
    	Locked synchronizers:
    	- java.util.concurrent.ThreadPoolExecutor$Worker@466276d8

@mingshl mingshl temporarily deployed to ml-commons-cicd-env July 22, 2024 18:10 — with GitHub Actions Inactive
@prudhvigodithi prudhvigodithi mentioned this pull request Jul 22, 2024
Closed
74 tasks
@Zhangxunmt
Copy link
Collaborator

Zhangxunmt commented Jul 22, 2024 •
edited
Loading

I see there are still 16 failed Integ tests. Probably they are not flaky tests any more. It may be just 1 error causing all these failures. Please check the CI for Linux in the test summary.

@mingshl
Copy link
Collaborator Author

mingshl commented Jul 23, 2024

I see there are still 16 failed Integ tests. Probably they are not flaky tests any more. It may be just 1 error causing all these failures. Please check the CI for Linux in the test summary.

The windows CI passed. Only the Linux CI is failing

@mingshl mingshl temporarily deployed to ml-commons-cicd-env July 23, 2024 23:20 — with GitHub Actions Inactive
@mingshl
Copy link
Collaborator Author

mingshl commented Jul 23, 2024

IT test failed due to timeout limit, retrying CI

@Zhangxunmt
Copy link
Collaborator

Zhangxunmt commented Jul 24, 2024 •
edited
Loading

approved. But to be on the safe side, let's wait for the CI pass before merging. Seems some ITs are still failing.

@mingshl mingshl temporarily deployed to ml-commons-cicd-env July 24, 2024 03:23 — with GitHub Actions Inactive
@mingshl
Copy link
Collaborator Author

mingshl commented Jul 24, 2024 •
edited
Loading

Still facing the timeout issue in CI

org.opensearch.ml.rest.RestMLDeployModelActionIT > testReDeployModel STANDARD_ERROR
    ???? 24, 2024 1:48:23 ?.?. com.carrotsearch.randomizedtesting.ThreadLeakControl$2 evaluate
    WARNING: Suite execution timed out: org.opensearch.ml.rest.RestMLDeployModelActionIT
    ==== jstack at approximately timeout time ====

Cannot reproduce locally. Local run IT success.

@mingshl
Copy link
Collaborator Author

mingshl commented Jul 24, 2024

will merge this PR and will watch if this timeout issue is happening to other PRs as well.

@mingshl mingshl merged commit 05f78af into opensearch-project:main Jul 24, 2024
6 of 8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
@mingshl @github-actions
Add initial search request inference processor (#2616)
5c09c4a 
* add initial search request inference processor

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* Add ITs for MLInferenceSearchRequestProcessor

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* skip running OPENAI when key is not present and fix yaml test issue

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

---------

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
(cherry picked from commit 05f78af)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
@mingshl @github-actions
Add initial search request inference processor (#2616)
076a7a2 
* add initial search request inference processor

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* Add ITs for MLInferenceSearchRequestProcessor

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* skip running OPENAI when key is not present and fix yaml test issue

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

---------

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
(cherry picked from commit 05f78af)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2024
Merged
mingshl added a commit to mingshl/ml-commons that referenced this pull request Jul 24, 2024
@mingshl
Add initial search request inference processor (opensearch-project#2616)
cc786f7 
* add initial search request inference processor

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* Add ITs for MLInferenceSearchRequestProcessor

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* skip running OPENAI when key is not present and fix yaml test issue

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

---------

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
mingshl added a commit that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @mingshl
[Backport 2.x] Add initial search request inference processor (#2730)
bf0c7fa 
* Add initial search request inference processor (#2616)

* add initial search request inference processor

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* Add ITs for MLInferenceSearchRequestProcessor

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* skip running OPENAI when key is not present and fix yaml test issue

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

---------

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
(cherry picked from commit 05f78af)

* resolve package import

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

---------

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Co-authored-by: Mingshi Liu <mingshl@amazon.com>
@b4sjoo b4sjoo added the v2.16.0 Issues targeting release v2.16.0 label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@b4sjoo b4sjoo b4sjoo approved these changes

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@samuel-oci samuel-oci Awaiting requested review from samuel-oci samuel-oci is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.16 v2.16.0 Issues targeting release v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingshl @Zhangxunmt @b4sjoo