Adding MLTask #24
Merged
Adding MLTask #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
reviewed
May 6, 2021
Adjust taskType and state to use Enum type.
Comment on lines
28
to
46
| @Getter | ||
| private final String taskId; | ||
|
|
||
| @Getter | ||
| private final MLTaskType taskType; | ||
|
|
||
| @Setter | ||
| @Getter | ||
| private MLTaskState state; | ||
|
|
||
| @Getter | ||
| private final Instant createTime; | ||
|
|
||
| @Getter | ||
| private final String modelId; | ||
|
|
||
| @Setter | ||
| @Getter | ||
| private String error; |
There was a problem hiding this comment.
Minor: move @Getter to above class definition to simplify the Getter annotation
There was a problem hiding this comment.
For this string error, not sure if it can meet our use case or not. we can keep it this way now and refactor it later when needed
weicongs-amazon
approved these changes
May 6, 2021
jackiehanyang
pushed a commit
that referenced
this pull request
Nov 16, 2021
* Add MLTask data model. * Align task type * Modify MLTaskTest case * Add error field to store failure message Adjust taskType and state to use Enum type. * Move @Getter to class level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add MLTask data model to model ML request(train/predict). Later this MLTask will be used in following scenarios:
Issues Resolved
Part of task and resource management
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.