Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to control auto-deploy behavior #2276

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Mar 26, 2024

Description

This PR introduced a boolean flag to control auto-deploy behavior. This boolean is wrapped with a new flat object field in order to avoid adding to much field to model index directly in the future. To make model index cleaner and maintainable.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env March 26, 2024 10:48 — with GitHub Actions Error
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env March 26, 2024 10:48 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env March 26, 2024 10:48 — with GitHub Actions Error
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 26, 2024 10:48 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 26, 2024 10:48 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 26, 2024 10:48 — with GitHub Actions Inactive
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 46.07843% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 81.30%. Comparing base (be56bcf) to head (abb2173).
Report is 2 commits behind head on main.

❗ Current head abb2173 differs from pull request most recent head 412fdd8. Consider uploading reports for the commit 412fdd8 to get more accurate results

Files Patch % Lines
...ommon/transport/register/MLRegisterModelInput.java 34.61% 8 Missing and 9 partials ⚠️
...ansport/upload_chunk/MLRegisterModelMetaInput.java 16.66% 6 Missing and 9 partials ⚠️
.../ml/common/transport/model/MLUpdateModelInput.java 18.75% 7 Missing and 6 partials ⚠️
...rc/main/java/org/opensearch/ml/common/MLModel.java 30.76% 6 Missing and 3 partials ⚠️
...ain/java/org/opensearch/ml/common/CommonValue.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2276      +/-   ##
============================================
- Coverage     81.42%   81.30%   -0.12%     
- Complexity     5853     5857       +4     
============================================
  Files           557      558       +1     
  Lines         23871    23952      +81     
  Branches       2493     2511      +18     
============================================
+ Hits          19436    19475      +39     
- Misses         3412     3441      +29     
- Partials       1023     1036      +13     
Flag Coverage Δ
ml-commons 81.30% <46.07%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 26, 2024 11:37 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 26, 2024 11:37 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 26, 2024 11:37 — with GitHub Actions Inactive
Zhangxunmt
Zhangxunmt previously approved these changes Mar 27, 2024
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env March 27, 2024 21:48 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env March 27, 2024 21:48 — with GitHub Actions Error
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 27, 2024 21:48 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 27, 2024 21:48 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 27, 2024 21:48 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 27, 2024 21:48 — with GitHub Actions Inactive
@b4sjoo b4sjoo merged commit 22fcaf0 into opensearch-project:main Mar 27, 2024
9 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 27, 2024
* Add a flag to control auto-deploy behavior

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Fix compilation

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Bump back schema version due to already bumped in guardrail pr

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
(cherry picked from commit 22fcaf0)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 27, 2024
* Add a flag to control auto-deploy behavior

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Fix compilation

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Bump back schema version due to already bumped in guardrail pr

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
(cherry picked from commit 22fcaf0)
b4sjoo added a commit that referenced this pull request Mar 27, 2024
* Add a flag to control auto-deploy behavior

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Fix compilation

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Bump back schema version due to already bumped in guardrail pr

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
(cherry picked from commit 22fcaf0)

Co-authored-by: Sicheng Song <sicheng.song@outlook.com>
b4sjoo added a commit that referenced this pull request Mar 27, 2024
* Add a flag to control auto-deploy behavior

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Fix compilation

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Bump back schema version due to already bumped in guardrail pr

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
(cherry picked from commit 22fcaf0)

Co-authored-by: Sicheng Song <sicheng.song@outlook.com>
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 27, 2024 22:38 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 27, 2024 22:38 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env March 27, 2024 22:38 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants