update remote model auto deploy tests in predict runner #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee,
HenryL27 and
sam-herman
as code owners
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Signed-off-by: Xun Zhang <xunzh@amazon.com>
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
approved these changes
Mar 19, 2024
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
@Zhangxunmt suggest add some IT for auto deploy in https://github.com/opensearch-project/ml-commons/blob/main/plugin/src/test/java/org/opensearch/ml/rest/RestMLRemoteInferenceIT.java |
Yes will do that in a separate PR. This one unblocks the current build for us and other teams. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
============================================
- Coverage 81.90% 81.28% -0.63%
- Complexity 5719 5828 +109
============================================
Files 547 557 +10
Lines 23075 23810 +735
Branches 2378 2480 +102
============================================
+ Hits 18900 19354 +454
- Misses 3230 3432 +202
- Partials 945 1024 +79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dhrubo-os
approved these changes
Mar 19, 2024
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Mar 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit 1a8b6eb)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit 1a8b6eb)
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 20, 2024
…roject#2237) Signed-off-by: Xun Zhang <xunzh@amazon.com>
Zhangxunmt
added a commit
that referenced
this pull request
Mar 20, 2024
Zhangxunmt
added a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old test of testExecuteTask_OnLocalNode_RemoteModel is not valid anymore after the auto deployment. This new test replace the old one with newest auto deployment.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.