Updates sample cert and admin keystore #2143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
sam-herman,
ylwu-amzn and
zane-neo
as code owners
DarshitChanpura
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
DarshitChanpura
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
DarshitChanpura
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
DarshitChanpura
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
DarshitChanpura
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
DarshitChanpura
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
should be merged post opensearch-project/security#4061 is merged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2143 +/- ##
=========================================
Coverage 81.85% 81.85%
Complexity 5660 5660
=========================================
Files 543 543
Lines 22857 22857
Branches 2350 2350
=========================================
Hits 18710 18710
Misses 3207 3207
Partials 940 940
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DarshitChanpura
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
DarshitChanpura
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
DarshitChanpura
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
approved these changes
Feb 22, 2024
ylwu-amzn
approved these changes
Feb 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 24, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 7a89a43)
ylwu-amzn
pushed a commit
that referenced
this pull request
Feb 27, 2024
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downstream change coming from security plugin: opensearch-project/security#4061
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.