parse tool input to map #2131
Merged
parse tool input to map #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2131 +/- ##
============================================
- Coverage 81.86% 81.86% -0.01%
- Complexity 5644 5658 +14
============================================
Files 543 543
Lines 22790 22856 +66
Branches 2333 2348 +15
============================================
+ Hits 18658 18711 +53
- Misses 3195 3206 +11
- Partials 937 939 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
approved these changes
Feb 19, 2024
b4sjoo
approved these changes
Feb 19, 2024
dhrubo-os
approved these changes
Feb 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 235fb9c)
dhrubo-os
pushed a commit
that referenced
this pull request
Feb 20, 2024
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chat agent runner will pass a string input json to tool , for example
"{'detectorName': 'abc', 'indices': 'sample-data' }", then the tool side need to parse the json string to Map, for example PPLTool.This PR parse the tool input json string to Map and put the parameters to tool's parameter map.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.