[Backport 2.12] system error handling #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* system error handling Signed-off-by: Jing Zhang <jngz@amazon.com> * remove NullPointerException from client error Signed-off-by: Jing Zhang <jngz@amazon.com> * replace jsonobject with ObjectMapper Signed-off-by: Jing Zhang <jngz@amazon.com> * add more UT Signed-off-by: Jing Zhang <jngz@amazon.com> * fix format issue Signed-off-by: Jing Zhang <jngz@amazon.com> * spotless Signed-off-by: Jing Zhang <jngz@amazon.com> --------- Signed-off-by: Jing Zhang <jngz@amazon.com> (cherry picked from commit c2a1d82)
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
rbhavna
approved these changes
Feb 7, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.12 #2051 +/- ##
============================================
- Coverage 82.58% 82.51% -0.07%
- Complexity 5583 5586 +3
============================================
Files 540 542 +2
Lines 22473 22516 +43
Branches 2289 2293 +4
============================================
+ Hits 18559 18579 +20
- Misses 2985 3002 +17
- Partials 929 935 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arjunkumargiri
approved these changes
Feb 7, 2024
ylwu-amzn
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c2a1d82 from #1893