Add data frame support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanghg08
approved these changes
Apr 13, 2021
Comment on lines
+25
to
+39
| default int intValue() { | ||
| throw new RuntimeException("the value isn't Integer type"); | ||
| } | ||
|
|
||
| default String stringValue() { | ||
| throw new RuntimeException("the value isn't String type"); | ||
| } | ||
|
|
||
| default double doubleValue() { | ||
| throw new RuntimeException("the value isn't Double type"); | ||
| } | ||
|
|
||
| default boolean booleanValue() { | ||
| throw new RuntimeException("the value isn't Boolean type"); | ||
| } |
dblock
reviewed
Apr 13, 2021
| } | ||
|
|
||
| @Test | ||
| public void read_StringValue() throws IOException { |
There was a problem hiding this comment.
Consider beefing up tests for empty strings here, and NULL values here/elsewhere where appropriate.
There was a problem hiding this comment.
Thanks. Add empty string check here. Null value isn't allowed for StringValue. Instead, add null check in StringValue UT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Testing
./gradlew build