Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add IndexMapping Tool #1934

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 849fecf from #1891

* Add IndexMapping Tool

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Improve description and make index a required parameter

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Add some more test coverage

Signed-off-by: Daniel Widdis <widdis@gmail.com>

---------

Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 849fecf)
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (e91e3a9) 82.92% compared to head (58e3999) 82.92%.

Files Patch % Lines
...g/opensearch/ml/engine/tools/IndexMappingTool.java 84.28% 7 Missing and 4 partials ⚠️
...a/org/opensearch/ml/engine/tools/CatIndexTool.java 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #1934   +/-   ##
=========================================
  Coverage     82.92%   82.92%           
- Complexity     5415     5423    +8     
=========================================
  Files           521      522    +1     
  Lines         21719    21787   +68     
  Branches       2214     2221    +7     
=========================================
+ Hits          18010    18067   +57     
- Misses         2813     2820    +7     
- Partials        896      900    +4     
Flag Coverage Δ
ml-commons 82.92% <82.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mingshl mingshl merged commit 021a899 into 2.x Jan 27, 2024
13 of 15 checks passed
@github-actions github-actions bot deleted the backport/backport-1891-to-2.x branch January 27, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants