Issue 1878/1879/1880 fixing index not found for model group/model/tasks #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Herman <sherman8915@gmail.com>
Signed-off-by: Samuel Herman <sherman8915@gmail.com>
sam-herman
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
sam-herman
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
sam-herman
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
sam-herman
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
sam-herman
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
sam-herman
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
sam-herman
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Signed-off-by: Samuel Herman <sherman8915@gmail.com>
sam-herman
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
sam-herman
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
sam-herman
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
sam-herman
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
sam-herman
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
sam-herman
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1889 +/- ##
=========================================
Coverage 82.63% 82.64%
Complexity 5391 5391
=========================================
Files 521 521
Lines 21724 21731 +7
Branches 2211 2211
=========================================
+ Hits 17952 17959 +7
Misses 2873 2873
Partials 899 899
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HenryL27
approved these changes
Jan 19, 2024
| @@ -162,7 +166,8 @@ public void search(SearchRequest request, ActionListener<SearchResponse> actionL | |||
| } | |||
| } | |||
|
|
|||
| private QueryBuilder rewriteQueryBuilder(QueryBuilder queryBuilder, List<String> modelGroupIds) { | |||
| @VisibleForTesting | |||
There was a problem hiding this comment.
the neural search guys told me to try not to use this, but ok
ylwu-amzn
approved these changes
Jan 19, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1889-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 41fac826c8fd1182f83c1f3f6b301bf17022eb2f
# Push it to GitHub
git push --set-upstream origin backport/backport-1889-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
sam-herman
deleted the
issue-1878-fixing-index-not-found-for-model-group
branch
@samuel-oci Seems there are some conflicts for 2.x. Can you help manually backport this PR to 2.x ? |
@ylwu-amzn what is the process? should I just create the backport branch and send the PR? |
|
@samuel-oci no need to create backport branch in ml-commons branch, just use your forked repo like this PR |
sam-herman
added a commit
to sam-herman/ml-commons
that referenced
this pull request
Jan 22, 2024
…ks (opensearch-project#1889) * adding tests for search of ML constructs Signed-off-by: Samuel Herman <sherman8915@gmail.com> * improve test coverage on MLSearchHandler Signed-off-by: Samuel Herman <sherman8915@gmail.com> * fix headers on test Signed-off-by: Samuel Herman <sherman8915@gmail.com> --------- Signed-off-by: Samuel Herman <sherman8915@gmail.com> (cherry picked from commit 41fac82) Signed-off-by: Samuel Herman <sherman8915@gmail.com>
5 tasks
@ylwu-amzn created #1895 |
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…ks (opensearch-project#1889) * adding tests for search of ML constructs Signed-off-by: Samuel Herman <sherman8915@gmail.com> * improve test coverage on MLSearchHandler Signed-off-by: Samuel Herman <sherman8915@gmail.com> * fix headers on test Signed-off-by: Samuel Herman <sherman8915@gmail.com> --------- Signed-off-by: Samuel Herman <sherman8915@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When model/model group/task is not created yet, return an empty search response instead of a broken 404 with cryptic index not found message.
More description in:
#1878
#1879
#1880
Issues Resolved
#1878
#1879
#1880
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.