Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add GetTool API and ListTools API #1850

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[Backport 2.x] Add GetTool API and ListTools API #1850

merged 1 commit into from
Jan 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport deb51f6 from #1818

@jackiehanyang @github-actions
Add GetTool API and ListTools API (#1818)
561dd91 
* Add GetTool API and ListTools API

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* rename externalTools parameter as toolMetadataList

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* spotless apply

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* add more unit tests

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* tweak unit test cases

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* increase test coverage

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* increase test coverage

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* add more tests

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* Include Type and Version in GetTool and ListTools API responses

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* tweak ListTools result format

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

* change term no version found to undefined

Signed-off-by: Jackie Han <jkhanjob@gmail.com>

---------

Signed-off-by: Jackie Han <jkhanjob@gmail.com>
(cherry picked from commit deb51f6)
@ylwu-amzn
Copy link
Collaborator

CI failed as text-davinci-003 has been deprecated. This will be fixed in Hailong's PR #1846

? ERROR][o.o.m.e.a.r.RemoteModel  ] [integTest-0] Failed to call remote model.
?  org.opensearch.OpenSearchStatusException: Error from remote service: {
?      "error": {
?          "message": "The model `text-davinci-003` has been deprecated, learn more here: https://platform.openai.com/docs/deprecations",
?          "type": "invalid_request_error",
?          "param": null,
?          "code": "model_not_found"
?      }
?  }

@mingshl mingshl merged commit 388fa33 into 2.x Jan 10, 2024
6 of 12 checks passed
@github-actions github-actions bot deleted the backport/backport-1818-to-2.x branch January 10, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingshl mingshl mingshl approved these changes

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ylwu-amzn @mingshl @jackiehanyang