-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model & user level throttling #1800
Conversation
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
…ations for clarification Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
This reverts commit 5a2d455.
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Is this PR ready to review? Spotless missing. Is that 111 files? Or other commits also added here? |
Main codes are ready to review, just some UTs are missing. This PR including some UT names refactor, but overall they are only about the throttling feature itself. |
Yeah it's a super large PR... |
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
common/src/main/java/org/opensearch/ml/common/controller/MLModelController.java
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/ml/action/update_cache/UpdateModelCacheTransportAction.java
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/controller/MLModelController.java
Show resolved
Hide resolved
added a few comments from user experience and data model in the OS index. Do you have a quip document to track all the APIs usages and examples that will be added in the PR? |
Addressed. For the API usage will added to the same quip we used to demo later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged with 2 major concerns from my view:
- There will be data redundancy in the Ml-Model because both user/model throttling are bind within the Ml-Model. It's not obvious that we can decouple them easily in the future.
- The APIs added in the PR should be all optional for users to run ml-commons. There shouldn't be any required setup for throttling unless someone needs to use throttling.
We can further discuss on the first one. For the second one, at this time all throttling related apis are optional for our user. The default behavior is pass for all requests (same as the previous). |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1800-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 50788de0bcf7a9509da6d2dabb23aab59d5a843d
# Push it to GitHub
git push --set-upstream origin backport/backport-1800-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* Enable in-place update model --------- Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
* Model & user level throttling (#1800) * Enable in-place update model --------- Signed-off-by: Sicheng Song <sicheng.song@outlook.com> * fix backport conflict Signed-off-by: Sicheng Song <sicheng.song@outlook.com> --------- Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
* Enable in-place update model --------- Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
* Enable in-place update model --------- Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Description
This PR should enable model and user level rate limiting on TextEmbedding model and all Remote model.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.