Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] hidden model implementation #1755

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d71c77f from #1736

* hidden model implementation

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* adding more unit tests

* adding more unit tests

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing spotless

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* adding more unit test in MLModelManager

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* addressing comments

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
(cherry picked from commit d71c77f)
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (16e2cdf) 81.31% compared to head (14179d5) 82.05%.

Files Patch % Lines
...h/ml/action/deploy/TransportDeployModelAction.java 68.60% 19 Missing and 8 partials ⚠️
.../java/org/opensearch/ml/utils/RestActionUtils.java 65.21% 6 Missing and 2 partials ⚠️
...h/ml/action/models/DeleteModelTransportAction.java 75.86% 0 Missing and 7 partials ⚠️
...arch/ml/action/models/GetModelTransportAction.java 87.50% 1 Missing and 2 partials ⚠️
...n/java/org/opensearch/ml/model/MLModelManager.java 81.25% 0 Missing and 3 partials ⚠️
...ain/java/org/opensearch/ml/common/CommonValue.java 0.00% 1 Missing ⚠️
...ansport/upload_chunk/MLRegisterModelMetaInput.java 92.85% 0 Missing and 1 partial ⚠️
...action/undeploy/TransportUndeployModelsAction.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1755      +/-   ##
============================================
+ Coverage     81.31%   82.05%   +0.73%     
- Complexity     4372     4430      +58     
============================================
  Files           425      425              
  Lines         17478    17605     +127     
  Branches       1849     1870      +21     
============================================
+ Hits          14213    14445     +232     
+ Misses         2539     2419     -120     
- Partials        726      741      +15     
Flag Coverage Δ
ml-commons 82.05% <80.97%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhrubo-os dhrubo-os merged commit 9262d13 into 2.x Dec 12, 2023
9 of 15 checks passed
@github-actions github-actions bot deleted the backport/backport-1736-to-2.x branch December 12, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants