-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] add new data fields in the memory layer and update tests #1753
Conversation
* add new data fields in the memory layer and update tests Signed-off-by: Xun Zhang <xunzh@amazon.com> * add more tests coverage and address comments Signed-off-by: Xun Zhang <xunzh@amazon.com> * address comments and more tests Signed-off-by: Xun Zhang <xunzh@amazon.com> --------- Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit 01cf00c)
@Zhangxunmt IT failed, take a look ?
|
This is usually a flaky test. @HenryL27 did you get time to look at this? Thanks |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1753 +/- ##
============================================
+ Coverage 81.31% 81.71% +0.39%
- Complexity 4372 4411 +39
============================================
Files 425 425
Lines 17478 17637 +159
Branches 1849 1862 +13
============================================
+ Hits 14213 14412 +199
+ Misses 2539 2477 -62
- Partials 726 748 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ylwu-amzn @dhrubo-os I rerun the test and it passed. Can you help approve this backport PR? Fixing the flaky test shouldn't be included in this backport. |
Backport 01cf00c from #1730