Add Search Task API and Refactor search actions and handlers #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <xunzh@amazon.com>
ylwu-amzn
reviewed
Feb 23, 2022
| public static FetchSourceContext getSourceContext(RestRequest request) { | ||
| String userAgent = Strings.coalesceToEmpty(request.header("User-Agent")); | ||
| if (!userAgent.contains(OPENSEARCH_DASHBOARDS_USER_AGENT)) { | ||
| return new FetchSourceContext(true, Strings.EMPTY_ARRAY, UI_METADATA_EXCLUDE); |
There was a problem hiding this comment.
ML plugin doesn't have UI, so no need to return ui_metadata.
There was a problem hiding this comment.
sure will do in the next PR.
ylwu-amzn
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Zhang xunzh@amazon.com
Description
Add Search Task API and Refactor search actions and handlers.
More unit tests will be added in the next PRs.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.