Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support float type in data frame #129

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Jan 26, 2022

Signed-off-by: Yaliang Wu ylwu@amazon.com

Description

Support float type in data frame.
@jackiehanyang , you need to add float type in MLCommonsOperator#convertRowIntoExprValue method.

Issues Resolved

#128

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn requested review from a team, jackiehanyang and Zhangxunmt January 26, 2022 06:33
@ylwu-amzn ylwu-amzn merged commit 82177a5 into opensearch-project:main Jan 26, 2022
@Zhangxunmt
Copy link
Collaborator

Lgtm!

@ylwu-amzn ylwu-amzn added the enhancement New feature or request label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants