Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jcenter dependency #121

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky amgalitz@amazon.com

Description

Removed jcenter dependency as it is no longer operating. We have mavenCentral() as a fallback.

Issues Resolved

resolves #120

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz requested a review from a team January 13, 2022 18:37
ylwu-amzn
ylwu-amzn previously approved these changes Jan 13, 2022
@ylwu-amzn
Copy link
Collaborator

ylwu-amzn commented Jan 13, 2022

Merging is blocked
The base branch requires all commits to be signed

Commit not signed?

@amitgalitz
Copy link
Member Author

Merging is blocked
The base branch requires all commits to be signed

Commit not signed?

Not sure, why that shows. I did sign it off and it even passed DCO workflow. Maybe I don't have write access to this repo?

dblock
dblock previously approved these changes Jan 13, 2022
@dblock
Copy link
Member

dblock commented Jan 13, 2022

This repo branch protection seems to require signed commits, as in PGP-signed (https://code.dblock.org/2021/04/16/adding-work-email-to-a-gpg-key-and-signing-git-commits.html).

Is that intentional? I can relax it.

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@amitgalitz amitgalitz dismissed stale reviews from dblock and ylwu-amzn via 0aa2f9a January 13, 2022 19:38
@amitgalitz
Copy link
Member Author

This repo branch protection seems to require signed commits, as in PGP-signed (https://code.dblock.org/2021/04/16/adding-work-email-to-a-gpg-key-and-signing-git-commits.html).

Is that intentional? I can relax it.

added PGP signature

@CEHENKLE
Copy link
Member

PGP signed commits was turned on by accident (AFAIK), so I've turned it off. Let me know if you actually meant to have it on,

@dblock dblock merged commit f4addc7 into opensearch-project:main Jan 13, 2022
@ylwu-amzn
Copy link
Collaborator

ylwu-amzn commented Jan 13, 2022

Thanks @CEHENKLE , I don't think we need that strict check now as ml-commons is public repo currently. Seems not so necessary to add one more barrier, especially for community users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove jcenter repository
4 participants