-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jcenter dependency #121
Conversation
Commit not signed? |
Not sure, why that shows. I did sign it off and it even passed DCO workflow. Maybe I don't have write access to this repo? |
This repo branch protection seems to require signed commits, as in PGP-signed (https://code.dblock.org/2021/04/16/adding-work-email-to-a-gpg-key-and-signing-git-commits.html). Is that intentional? I can relax it. |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
df143ac
to
0aa2f9a
Compare
added PGP signature |
PGP signed commits was turned on by accident (AFAIK), so I've turned it off. Let me know if you actually meant to have it on, |
Thanks @CEHENKLE , I don't think we need that strict check now as ml-commons is public repo currently. Seems not so necessary to add one more barrier, especially for community users |
Signed-off-by: Amit Galitzky amgalitz@amazon.com
Description
Removed jcenter dependency as it is no longer operating. We have mavenCentral() as a fallback.
Issues Resolved
resolves #120
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.