Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix - Breaking Change Main OpenSearch project - action move to core #1200 #1206

Merged

Conversation

MitchellGale
Copy link
Contributor

Description

Corrects imports for new location with regards to opensearch-project/OpenSearch#9082.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@MitchellGale MitchellGale temporarily deployed to ml-commons-cicd-env August 15, 2023 20:37 — with GitHub Actions Inactive
@MitchellGale MitchellGale temporarily deployed to ml-commons-cicd-env August 15, 2023 20:37 — with GitHub Actions Inactive
@MitchellGale MitchellGale temporarily deployed to ml-commons-cicd-env August 15, 2023 20:37 — with GitHub Actions Inactive
@MitchellGale MitchellGale temporarily deployed to ml-commons-cicd-env August 15, 2023 20:37 — with GitHub Actions Inactive
@ylwu-amzn
Copy link
Collaborator

Thanks for fixing the breaking changes. Will approve once the Github CI pass

@MitchellGale
Copy link
Contributor Author

MitchellGale commented Aug 15, 2023

@ylwu-amzn Seems like BWC has been failing for 3 weeks on the 2.x branch. That can probably be addressed after this PR without impact. https://github.com/opensearch-project/ml-commons/actions/workflows/test_bwc.yml?query=branch%3A2.x

@ylwu-amzn
Copy link
Collaborator

@ylwu-amzn Seems like BWC has been failing for 3 weeks on the 2.x branch. That can probably be addressed after this PR without impact. https://github.com/opensearch-project/ml-commons/actions/workflows/test_bwc.yml?query=branch%3A2.x

Yes, the BWC seems not related with this PR. It failed weeks ago. I guess the reason is 2.10 OpenSearch not ready yet, so we can't start 2.10 cluster to do BWC test.

@dhrubo-os dhrubo-os merged commit 5c2dc5d into opensearch-project:2.x Aug 15, 2023
@MitchellGale
Copy link
Contributor Author

Thanks for merge!

HenryL27 pushed a commit to HenryL27/ml-commons that referenced this pull request Aug 17, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
ylwu-amzn pushed a commit that referenced this pull request Aug 17, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants